Skip to content

[fix] swig jar package module#7344

Merged
waruqi merged 1 commit intoxmake-io:devfrom
binLep:dev
Feb 24, 2026
Merged

[fix] swig jar package module#7344
waruqi merged 1 commit intoxmake-io:devfrom
binLep:dev

Conversation

@binLep
Copy link
Contributor

@binLep binLep commented Feb 24, 2026

之前的打包方式,打包后的类路径为

build..gens.mcrps.linux.x86_64.release.rules.swig.com.example.MyName;

build和gen之间还有个逗号,更无法解析了

↓↓↓

正常来说,类路径应该是

com.example.MyName

目前修改了一下打包参数,本地用 AOSC 系统测试是没问题的

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @binLep, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求解决了 SWIG 生成的 JAR 包中类路径不正确的问题。通过调整 jar 命令的打包参数,确保生成的 JAR 文件能够正确地反映预期的类结构,从而使 Java 模块能够被正确加载和解析。

Highlights

  • 修复 SWIG JAR 包的类路径问题: 修正了 jar 命令的打包参数,确保生成的 JAR 包中的类路径结构正确,避免了之前因 build..gens 路径导致无法解析的问题。

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • xmake/rules/swig/build_module_file.lua
    • 更新了 jar 命令的参数,以正确设置 JAR 包的根目录。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

这次的 Pull Request 修复了 SWIG Java 模块打包时类路径不正确的问题。之前的 jar 命令会将整个编译输出目录打包进去,导致类路径包含了构建目录的完整路径。通过在 jar 命令中使用 -C 参数,新的打包方式会先切换到 class 文件所在的目录,然后再将文件打包到 jar 文件中,从而确保了正确的类路径结构。这个修改是正确的,并且解决了描述中提到的问题。代码简洁明了,没有发现其他问题。

@binLep binLep closed this Feb 24, 2026
@binLep binLep reopened this Feb 24, 2026
@waruqi waruqi added this to the v3.0.8 milestone Feb 24, 2026
@waruqi waruqi merged commit e1c9477 into xmake-io:dev Feb 24, 2026
64 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants