Skip to content

update tbox to fix start process on win7#7339

Merged
waruqi merged 1 commit intodevfrom
winproc
Feb 23, 2026
Merged

update tbox to fix start process on win7#7339
waruqi merged 1 commit intodevfrom
winproc

Conversation

@waruqi
Copy link
Member

@waruqi waruqi commented Feb 23, 2026

@waruqi waruqi added this to the v3.0.8 milestone Feb 23, 2026
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Feb 23, 2026

Summary of Changes

Hello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the tbox submodule to a newer version. This update is crucial for fixing a reported issue where processes failed to start correctly on Windows 7, ensuring better compatibility and stability for users on that operating system.

Highlights

  • Submodule Update: Updated the tbox submodule to a newer commit (d0138aad74d1dda1fffbee2f6fc0a8f869d8481c) to incorporate upstream fixes.
  • Windows 7 Compatibility: The tbox update specifically addresses an issue with starting processes on Windows 7, resolving a reported bug.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • core/src/tbox/tbox
    • Updated the tbox submodule reference to commit d0138aad74d1dda1fffbee2f6fc0a8f869d8481c from de475fef05346a7603efea54d77afead7a16daca.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@waruqi waruqi requested a review from luadebug February 23, 2026 04:41
gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 23, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the tbox submodule to commit d0138aad74d1dda1fffbee2f6fc0a8f869d8481c. This update is intended to fix a process startup issue on Windows 7, as referenced in the pull request description and linked issues. The change is straightforward and correctly updates the submodule reference to the version containing the fix.

@waruqi waruqi mentioned this pull request Feb 23, 2026
Closed
@luadebug
Copy link
Member

luadebug commented Feb 23, 2026 •
edited
Loading

Alright so how would I acquire prebuilt xmake with this PR changes?
& ([ScriptBlock]::Create((irm https://xmake.io/psget.text))) -version winproc
probably would not work.

@waruqi
Copy link
Member Author

waruqi commented Feb 23, 2026 •
edited
Loading

  • Windows / build (windows-2022, x86) (push)

Download installer.exe from ci artifacts. https://github.com/xmake-io/xmake/actions/runs/22293147512?pr=7339

xmake-latest.win64.exe

@waruqi waruqi merged commit 92ca4c1 into dev Feb 23, 2026
74 checks passed
@waruqi waruqi deleted the winproc branch February 23, 2026 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luadebug luadebug Awaiting requested review from luadebug

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.0.8

Development

Successfully merging this pull request may close these issues.

2 participants

@waruqi @luadebug