add winos.file_signature function to retrieve file signature information by luadebug · Pull Request #7333 · xmake-io/xmake

luadebug · 2026-02-20T14:48:14Z

Attempt to continue working on #7326 as I accidentally broke branch :(

TODO that still does not work.

Resolves: #5629

Idea is that we can check for signature owner name GIGA-BYTE ... and if that is it and executable name is GCC.exe we should skip/filter out that .exe from find_tool("gcc")/find_gcc function at that case.

Currently I see:

Certainly mine wrapper over find_gcc/find_tool might be not correct... :/

Yet they should return void or either another GCC.exe. Maybe this would work or maybe not.

…fullpath as file_signature would not work without full path provided

…ive paths

Added reference to GitHub issue regarding GIGA-BYTE signed gcc.exe.

gemini-code-assist · 2026-02-20T14:48:34Z

Summary of Changes

Hello @luadebug, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances Xmake's Windows compatibility and robustness by integrating digital file signature verification. The primary goal is to prevent potential issues arising from specific gcc.exe versions signed by 'GIGA-BYTE' by introducing a check during program detection. This involves adding core C-level functionality for signature retrieval and exposing it to the Lua scripting environment, along with updating build configurations to link against the required Windows cryptographic libraries.

Highlights

Windows File Signature Check: Introduced new functionality to retrieve digital signature information for files on Windows, including whether a file is signed, trusted, and the signer's name.
GCC Gigabyte Signature Prevention: Implemented a mechanism to detect and prevent the use of gcc.exe executables signed by 'GIGA-BYTE' on Windows, addressing a known issue (xmake会将技嘉主板的管理面板误认为是gcc #5629).
Windows API Integration: Added necessary wintrust and crypt32 library links and linker flags for Windows and MinGW builds to support the new file signature checking functionality.
Lua Sandbox Exposure: Exposed the new file_signature function to the Lua sandbox, allowing Lua scripts to query file signature information.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

core/src/cli/xmake.lua
- Added wintrust and crypt32 to system links for Windows builds.
core/src/cli/xmake.sh
- Added -lwintrust and -lcrypt32 linker flags for MinGW builds.
core/src/xmake/engine.c
- Declared and registered the new xm_winos_file_signature function.
core/src/xmake/winos/file_signature.c
- Added a new source file implementing the xm_winos_file_signature function to retrieve digital signature details for files on Windows.
core/xmake.lua
- Added wintrust and crypt32 to general links for Windows builds.
xmake/core/sandbox/modules/import/lib/detect/find_program.lua
- Renamed the local variable for the base/winos module from option to winos.
xmake/core/sandbox/modules/winos.lua
- Exposed the new file_signature function to the sandbox environment.
xmake/modules/detect/tools/find_gcc.lua
- Implemented check_gcc_gigabyte and _check_gcc_on_windows functions to verify gcc.exe digital signatures.
- Modified the main function to utilize the new signature check for gcc.exe on Windows hosts.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

luadebug · 2026-02-20T14:51:04Z

@waruqi LGTM

gemini-code-assist

Code Review

This pull request introduces a file signature verification feature for Windows and uses it to address an issue with a non-standard gcc.exe provided by Gigabyte. The overall implementation is good, but I've identified a couple of areas for improvement: a logic bug in the GCC detection script that could lead to incorrect results, and some dead code in the new C file for signature checking. My review includes specific suggestions to fix these issues.

xmake/modules/detect/tools/find_gcc.lua

core/src/xmake/winos/file_signature.c

luadebug added 30 commits February 15, 2026 19:45

add winos.file_signature function to retrieve file signature information

1e15fe7

retry

1aa5aba

Try filter GCC.exe

84420e5

retry MinGW

a8a2c62

retry for mingw

8d8bcef

Fix file_signature assignment in winos.lua

227449f

Clear

b82ccd6

revert

fc17a30

Test for find_program

e7fe0d2

retry

af2c806

wrap find_program

0d4a423

try improve wrapper. it wont work if we pass just gcc.exe instead of …

92cbb94

…fullpath as file_signature would not work without full path provided

enhance signature check for gcc.exe to handle both absolute and relat…

caf37bd

…ive paths

Update comment to include issue reference for gcc.exe

f338f19

Added reference to GitHub issue regarding GIGA-BYTE signed gcc.exe.

try move into find_gcc

11cc0a0

try wrap to style

86b1f8b

retry find_gcc

1ef8c05

retry

f024c37

retry

56581ec

retry

530d874

retry

6a89f38

todo

994c838

tb_wtoa

387e1c2

clear

3774d82

revert ok, errors = sandbox.load(opt.check, program)

05ebd2e

try fix norunfile = true

26d3ba6

todo

0b9f1b8

refactor: enhance gigabyte gcc check and integrate custom check option

1e2596c

retry

4879e24

retry

ad77b2a

luadebug and others added 19 commits February 19, 2026 00:31

retry?

3b5a2eb

fixup

d9d08b4

Update find_gcc.lua

b065878

Merge branch 'xmake-io:dev' into sign

bff076b

Test

b66b14a

fixup

c93f823

add haiku ci

cc3ccae

enable force-utf8 for haiku

4240000

update tbox

457b14d

update lower

92048d4

fix ci

e7837a8

update tbox

9e9906c

update haiku ci

d7ec0e8

update haiku ci

c055710

fix builddir

373932b

improve tests for haiku

175e26d

fix tmpdir for haiku

d98330b

improve os.tmpdir

9f1c3a8

update comments

0b89554

luadebug changed the title ~~Sign2~~ add winos.file_signature function to retrieve file signature information Feb 20, 2026

gemini-code-assist bot reviewed Feb 20, 2026

View reviewed changes

xmake/modules/detect/tools/find_gcc.lua Outdated Show resolved Hide resolved

core/src/xmake/winos/file_signature.c Outdated Show resolved Hide resolved

waruqi and others added 3 commits February 20, 2026 23:04

Update file_signature.c

b59a110

Merge branch 'sign' of https://github.com/luadebug/xmake into sign

3d947bc

resolve gemini

97a4ee3

waruqi added this to the v3.0.8 milestone Feb 21, 2026

waruqi merged commit abe908e into xmake-io:dev Feb 21, 2026
37 checks passed

luadebug deleted the sign2 branch February 21, 2026 14:23

waruqi mentioned this pull request Feb 21, 2026

xmake会将技嘉主板的管理面板误认为是gcc #5629

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

add winos.file_signature function to retrieve file signature information#7333

add winos.file_signature function to retrieve file signature information#7333
waruqi merged 60 commits intoxmake-io:devfrom
luadebug:sign2

luadebug commented Feb 20, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Feb 20, 2026

Uh oh!

luadebug commented Feb 20, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

luadebug commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Feb 20, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

luadebug commented Feb 20, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

luadebug commented Feb 20, 2026 •

edited

Loading