Conversation
Summary of ChangesHello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances package management by providing more granular control over the retention of package source code. It introduces a new policy and associated logic to determine when source directories should be preserved, which is particularly beneficial for debugging, inspection, or integration with tools that require access to the source. The changes ensure that source cleanup is conditional, aligning with user preferences and development needs. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new policy package.keep_source to control whether a package's source code is kept after installation. This is implemented by adding a new has_source() method to the package instance, which checks for various conditions like debug mode or the new policy. The changes correctly apply this new logic to prevent source directory cleanup and to enable CMAKE_EXPORT_COMPILE_COMMANDS when sources are kept. My feedback includes a suggestion to simplify the implementation of the new has_source() function for better readability and conciseness.
|
Is the idea of issue is to keep source next to project directory but not next to Downloads folder? |
keep |
#7307