Skip to content

Add libdir,includedir,bindir support for install/uninstall#7300

Merged
waruqi merged 2 commits intodevfrom
install
Feb 6, 2026
Merged

Add libdir,includedir,bindir support for install/uninstall#7300
waruqi merged 2 commits intodevfrom
install

Conversation

@waruqi
Copy link
Member

@waruqi waruqi commented Feb 6, 2026 •
edited
Loading

@waruqi waruqi added this to the v3.0.7 milestone Feb 6, 2026
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Feb 6, 2026

Summary of Changes

Hello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the flexibility of the xmake install and xmake uninstall commands. By replacing a single, overarching 'prefix' option with dedicated options for binaries, libraries, and includes, users gain finer-grained control over where different components of their projects are placed. This change aligns with common practices for package management and system integration, making xmake more adaptable to diverse deployment scenarios.

Highlights

  • Granular Installation Paths: The generic 'prefix' option for installation and uninstallation has been replaced with more specific 'bindir', 'libdir', and 'includedir' options, allowing users to define distinct paths for binaries, libraries, and include files.
  • New Command-Line Options: New command-line arguments --bindir, --libdir, and --includedir have been introduced for both xmake install and xmake uninstall commands, providing direct control over these specific installation directories.
  • Updated Path Resolution Logic: The internal logic for resolving installation directories has been updated to prioritize these new specific options, falling back to existing configurations if not explicitly set.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • xmake/actions/install/install_admin.lua
    • Updated the main function signature to accept bindir, libdir, and includedir parameters instead of prefix.
    • Added validation to set empty string directory parameters to nil.
    • Modified option setting to use the new bindir, libdir, and includedir values.
  • xmake/actions/install/main.lua
    • Adjusted the sudo.execl call to pass the new bindir, libdir, and includedir options to install_admin.lua.
  • xmake/actions/install/xmake.lua
    • Introduced new command-line options --bindir, --libdir, and --includedir for the install task, with default paths relative to installdir.
    • Removed the prefix option from the install task definition.
  • xmake/actions/uninstall/main.lua
    • Adjusted the sudo.execl call to pass the new bindir, libdir, and includedir options to uninstall_admin.lua.
  • xmake/actions/uninstall/uninstall_admin.lua
    • Updated the main function signature to accept bindir, libdir, and includedir parameters instead of prefix.
    • Added validation to set empty string directory parameters to nil.
    • Modified option setting to use the new bindir, libdir, and includedir values.
  • xmake/actions/uninstall/xmake.lua
    • Introduced new command-line options --bindir, --libdir, and --includedir for the uninstall task, with default paths relative to installdir.
    • Removed the prefix option from the uninstall task definition.
  • xmake/core/project/target.lua
    • Modified bindir(), libdir(), and includedir() functions to first check for explicitly set baseoption values.
    • Implemented logic to handle both absolute and relative paths for the new directory options, normalizing them as needed.
Activity
  • No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@waruqi waruqi mentioned this pull request Feb 6, 2026
Closed
gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 6, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for libdir, includedir, and bindir to the install and uninstall actions, which is a great feature. The implementation is mostly correct, but I've found a few areas for improvement:

  • There's a critical syntax error in uninstall_admin.lua due to an extra end statement.
  • In install/main.lua and uninstall/main.lua, nil values might be passed to sudo.execl, which could be a bug. I've suggested a fix.
  • There's some code duplication in install_admin.lua, uninstall_admin.lua, and core/project/target.lua. I've left comments with suggestions on how to refactor this to improve maintainability.

Overall, good work. Please address the critical and high severity issues.

@waruqi waruqi merged commit 4780a46 into dev Feb 6, 2026
71 of 78 checks passed
@waruqi waruqi deleted the install branch February 6, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.0.7

Development

Successfully merging this pull request may close these issues.

1 participant

@waruqi