Skip to content

improve vcvars#7290

Merged
waruqi merged 7 commits intodevfrom
vs
Feb 4, 2026
Merged

improve vcvars#7290
waruqi merged 7 commits intodevfrom
vs

Conversation

@waruqi
Copy link
Member

@waruqi waruqi commented Feb 3, 2026

  • Before adding new features and new modules, please go to issues to submit the relevant feature description first.
  • Write good commit messages and use the same coding conventions as the rest of the project.
  • Please commit code to dev branch and we will merge into master branch in feature
  • Ensure your edited codes with four spaces instead of TAB.
  • 增加新特性和新模块之前，请先到issues提交相关特性说明，经过讨论评估确认后，再进行相应的代码提交，避免做无用工作。
  • 编写友好可读的提交信息，并使用与工程代码相同的代码规范，代码请用4个空格字符代替tab缩进。
  • 请提交代码到dev分支，如果通过，我们会在特定时间合并到master分支上。
  • 为了规范化提交日志的格式，commit消息，不要用中文，请用英文描述。

@waruqi waruqi added this to the v3.0.7 milestone Feb 3, 2026
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Feb 3, 2026

Summary of Changes

Hello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the detection and handling of Visual Studio environment variables within the find_vstudio.lua module. The changes primarily focus on improving the consistency, robustness, and clarity of how these variables are initialized, parsed, and accessed. By standardizing variable casing and enhancing parsing logic, the module's ability to reliably configure Visual Studio environments is improved.

Highlights

  • Refactored vcvars Initialization: The list of Visual Studio environment variables (vcvars) has been moved from a global scope to inside the get_vcvars function, improving encapsulation and scope management.
  • Standardized Environment Variable Casing: All Visual Studio environment variable names in the vcvars list are now consistently defined in uppercase (e.g., PATH instead of path), aligning with standard environment variable conventions.
  • Improved Environment Variable Parsing Robustness: The parsing logic for environment variables extracted from vcvarsall.bat output in _load_vcvarsall_impl now includes explicit checks to ensure that both the variable name and value are non-empty before being stored, preventing the inclusion of malformed entries.
  • Simplified Variable Handling: Redundant code for removing empty vcvars entries and explicit conversion from lowercase path/lib/include to their uppercase counterparts has been removed, as the new parsing and naming conventions make these steps unnecessary.
  • Consistent Variable Lookup: The _check_vcvarsall_env function no longer attempts a fallback to lowercase variable names when looking up new values, reinforcing the consistent uppercase naming convention.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • xmake/modules/detect/sdks/find_vstudio.lua
    • Moved the vcvars table definition from global scope to within the get_vcvars function.
    • Updated all environment variable names in the vcvars list to use uppercase (e.g., PATH, LIB).
    • Added checks for non-empty variable names and values during parsing in _load_vcvarsall_impl.
    • Removed the explicit loop for clearing empty vcvars entries.
    • Eliminated the conversion logic from lowercase path, lib, libpath, include to their uppercase equivalents.
    • Removed the lowercase fallback lookup for value_new in _check_vcvarsall_env.
Activity
  • The pull request description includes general contribution guidelines in both English and Chinese, but no specific activity related to the review or progress of this particular change.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 3, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the handling of Visual Studio environment variables (vcvars) in find_vstudio.lua. The vcvars list is moved into the get_vcvars function to limit its scope, and key environment variable names like PATH and LIB are now correctly uppercased. This removes the need for later case conversion logic, simplifying the code. Additionally, parsing of environment variables from vcvarsall.bat output is made more robust by checking for empty names and values. These changes improve code quality, maintainability, and correctness. I have one minor suggestion to further simplify a conditional check.

@waruqi waruqi merged commit 8f34a92 into dev Feb 4, 2026
72 of 75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.0.7

Development

Successfully merging this pull request may close these issues.

1 participant

@waruqi