Improve Windows OS shell detection cmd/pwsh... by luadebug · Pull Request #7285 · xmake-io/xmake

luadebug · 2026-01-31T16:29:30Z

#6927
Adds process list winos function.
Sort of attempt to acquire shell from parent process ID.

gemini-code-assist · 2026-01-31T16:29:47Z

Summary of Changes

Hello @luadebug, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new capability for Xmake to query and list running processes on Windows, significantly enhancing its interaction with the operating system. This new process enumeration feature is then integrated to provide a more robust and accurate method for detecting the parent shell on Windows, improving the overall reliability of shell-related functionalities within Xmake.

Highlights

New Windows Process Enumeration API: A new C function, xm_winos_processes, has been added and exposed to Lua, enabling Xmake to enumerate running processes on Windows, retrieving their names, PIDs, and parent PIDs.
Improved Windows Shell Detection: The tty._find_shell_from_parent function now utilizes the new Windows process enumeration API to accurately identify the parent shell by traversing the process tree, supporting common shells like zsh, bash, PowerShell, and cmd.
Refactored Shell Detection Logic: Windows-specific shell detection logic has been centralized within tty._find_shell_from_parent, removing redundant checks from tty.shell() and streamlining the overall shell identification process.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a more robust method for detecting the shell on Windows by traversing the parent process tree, which is a significant improvement over the previous heuristic-based approach. A new C function to list processes on Windows is implemented and integrated into the Lua modules. The code is clean and well-structured. I have one suggestion to improve code maintainability by refactoring a hardcoded list.

xmake/core/base/tty.lua

core/src/xmake/os/processes.c

xmake/core/base/tty.lua

luadebug added 2 commits January 31, 2026 17:29

add winos_processes function to retrieve process information on Windows

e494d44

add process retrieval for Windows in tty and winos modules

b56818e

gemini-code-assist bot reviewed Jan 31, 2026

View reviewed changes

xmake/core/base/tty.lua Outdated Show resolved Hide resolved

luadebug changed the title ~~Shell~~ Improve Windows OS shell detection cmd/pwsh... Jan 31, 2026