Improve os.isexec by waruqi · Pull Request #7278 · xmake-io/xmake

waruqi · 2026-01-29T15:48:58Z

#7274

…iles

…or Windows

…d add PE header checks

…executables

…mline PE header validation for Windows executables

…utable handling

…removing redundant extension checks

…uffixes

gemini-code-assist · 2026-01-29T15:49:23Z

Summary of Changes

Hello @waruqi, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the os.isexec function, especially for Windows environments, by implementing more comprehensive executable file detection mechanisms. It introduces new core functionalities for file access permission checks and binary format identification, making the system more robust in determining if a given file is executable across different platforms and file types.

Highlights

Refactored Binary Format Detection: The logic for detecting binary file formats (like COFF, ELF, Mach-O, AR, PE) has been refactored into a dedicated function, xm_binutils_format_detect, and moved to a new source file, core/src/xmake/binutils/format.c. This centralizes and improves the robustness of format identification, including enhanced PE format detection.
New os.access Function: A new Lua function, os.access, has been introduced, backed by a C implementation (core/src/xmake/os/access.c). This function allows checking file permissions (read, write, execute) directly, providing a more granular control over file access checks.
Improved os.isexec Logic: The os.isexec function has been significantly enhanced, particularly for Windows. It now checks for a broader range of executable file extensions (including .ps1, .sh), leverages the new binutils.format to detect PE executables, and identifies shebang (#!) scripts. For non-Windows systems, it now utilizes the new os.access function to verify execute permissions.
Exposed binutils.format to Lua: The binary format detection functionality is now exposed to Lua scripts via binutils.format, allowing users to programmatically determine the format of a given binary file.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request significantly improves the os.isexec function by making it more robust, especially on Windows. It correctly checks for executable permissions on Unix-like systems and adds checks for PE headers and shebangs on Windows. The refactoring of the binary format detection logic from an inline function to a separate C file is a good architectural improvement that enhances code organization and maintainability.

I've found one issue in xmake/core/base/binutils.lua where a change seems to have introduced unreachable code and altered the function's behavior when the C implementation is not available.

xmake/core/base/binutils.lua

waruqi · 2026-01-30T02:13:40Z

/gemini review

gemini-code-assist

Code Review

This pull request significantly improves the os.isexec function, making it much more robust, especially on Windows where it now correctly identifies executables by format in addition to file extension. The refactoring of the binary format detection logic into a separate, more comprehensive module is a great architectural improvement. The addition of os.access for permission checking on Unix-like systems is also a welcome change. The new tests for both binutils.format and os.isexec are thorough. I've found one critical issue and a couple of minor suggestions for code consistency.

xmake/core/base/os.lua

core/src/xmake/binutils/format.c

luadebug added 16 commits January 28, 2026 11:14

Add os.access function for file access checking

c1a0fd8

Enhance os.isexec function to support Windows executable checks

3770cbb

Enhance os.isexec function to correctly identify Windows executable f…

9c86aa7

…iles

Add parse_pe function to check for PE headers and enhance os.isexec f…

a258bf4

…or Windows

Enhance os.isexec function to improve Windows executable detection an…

fa12bdf

…d add PE header checks

Refine os.isexec function to improve architecture checks for Windows …

a45f1db

…executables

Enhance os.isexec function to include .exe extension checks and strea…

fdc2242

…mline PE header validation for Windows executables

Merge branch 'dev' into isexec

c8121df

Remove parse_pe function and related tests to streamline Windows exec…

811e010

…utable handling

Enhance os.isexec function to support .sh files as executable extensions

c5d5e3b

Refactor os.isexec function to simplify Windows executable checks by …

435178d

…removing redundant extension checks

Enhance os.isexec function to support additional Windows executable s…

38a8b69

…uffixes

Add is_pefile function to check for PE file signatures on Windows

be399ab

Refactor access.c to improve documentation and formatting

e7fba25

Rename "is_pe_file" to "is_pefile" for consistency in function naming

31166bf

Fix function name in Windows functions array for consistency

0d0e9a3

waruqi mentioned this pull request Jan 29, 2026

Add os.access function for file access checking #7274

Merged

gemini-code-assist bot reviewed Jan 29, 2026

View reviewed changes

xmake/core/base/binutils.lua Show resolved Hide resolved

waruqi added 3 commits January 30, 2026 00:54

add bintuils.format

148404f

improve binutils.format

499feec

improve format

954b113

waruqi marked this pull request as ready for review January 30, 2026 02:13

gemini-code-assist bot reviewed Jan 30, 2026

View reviewed changes

xmake/core/base/os.lua Outdated Show resolved Hide resolved

core/src/xmake/binutils/format.c Outdated Show resolved Hide resolved

core/src/xmake/binutils/format.c Show resolved Hide resolved

waruqi added this to the v3.0.7 milestone Jan 30, 2026

waruqi merged commit 51a68ee into dev Jan 30, 2026
71 of 73 checks passed

waruqi deleted the isexec branch January 30, 2026 09:28

waruqi added 2 commits January 30, 2026 21:00

improve format

cd457f2

improve comments

b62d053

waruqi added 14 commits January 30, 2026 22:32

fix binutils

4ce1e34

add binutils tests

c50a3cb

detect shebang format

9b87a6b

detect ape format

8a9d19e

fix os.isexec

5c268c2

fix os.isexec

ba2d6e5

improve os.isexec

e299709

add some comments

438a5a9

optimize os.isexec

6ea3339

improve binutils test

6894de1

improve errors

e836941

improve format.c

7fee203

fix get programfile for cosmocc

42dd40e

ignore ape format

d309d78

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Improve os.isexec#7278

Improve os.isexec#7278
waruqi merged 35 commits intodevfrom
isexec

waruqi commented Jan 29, 2026

Uh oh!

gemini-code-assist bot commented Jan 29, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

waruqi commented Jan 30, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

waruqi commented Jan 29, 2026

Uh oh!

gemini-code-assist bot commented Jan 29, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

waruqi commented Jan 30, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants