Skip to content

add dependency file generation for Nim source files#7268

Merged
waruqi merged 3 commits intoxmake-io:devfrom
luadebug:nim-increment
Jan 27, 2026
Merged

add dependency file generation for Nim source files#7268
waruqi merged 3 commits intoxmake-io:devfrom
luadebug:nim-increment

Conversation

@luadebug
Copy link
Member

@luadebug luadebug commented Jan 26, 2026 •
edited
Loading

#6488

Lets assume we have got project like:

main.nim

import something
echo "Hello, world!"

something.nim

echo "Hello from something!"

xmake.lua

set_project("import_module")
add_rules("mode.debug", "mode.release")

target("import_module")
    set_kind("binary")
    add_files("main.nim")

Once we go for xmake run it works, but once we edit something.nim file manually with vscode editor for example and save it to

something.nim

echo "Hello from something!"

import std/[times]
const buildTime = getTime()
echo "Project builded at: ", buildTime

and use xmake b import_module && xmake run it would skip our changes and executable would not execute those 3 new lines.

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Jan 26, 2026

Summary of Changes

Hello @luadebug, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Nim build rule within xmake to correctly handle dependencies between Nim source files. Previously, xmake would not detect changes in imported Nim modules, leading to stale builds. The changes integrate Nim's native dependency generation, allowing xmake to accurately track all relevant source files and trigger recompilations when any dependent module is modified, thus ensuring build correctness.

Highlights

  • Dependency Generation for Nim: Introduced a mechanism to generate dependency files (.deps) for Nim source files by invoking the Nim compiler with the --genScript flag.
  • Dependency Parsing and Tracking: Implemented logic to parse the generated .deps files, extracting all imported Nim modules and adding them to dependinfo.files for xmake's dependency tracking.
  • Improved Build Correctness: Ensures that xmake correctly detects changes in imported Nim modules, preventing skipped builds and guaranteeing that targets are recompiled when their dependencies are updated.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 26, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds dependency file generation for Nim source files, which is a great improvement for incremental builds. The implementation correctly uses nim --genScript to generate dependency information. My review includes a suggestion to make the implementation more robust by handling potential errors during script generation and by correctly dealing with the default nimcache directory location.

waruqi
waruqi reviewed Jan 27, 2026
View reviewed changes
waruqi
waruqi reviewed Jan 27, 2026
View reviewed changes
@waruqi waruqi merged commit a217ee2 into xmake-io:dev Jan 27, 2026
34 of 38 checks passed
@waruqi waruqi added this to the v3.0.7 milestone Jan 27, 2026
@luadebug luadebug mentioned this pull request Feb 18, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@waruqi waruqi waruqi left review comments

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.0.7

Development

Successfully merging this pull request may close these issues.

2 participants

@luadebug @waruqi