Skip to content

fix pch header extension#7266

Merged
waruqi merged 3 commits intodevfrom
pch
Jan 27, 2026
Merged

fix pch header extension#7266
waruqi merged 3 commits intodevfrom
pch

Conversation

@waruqi
Copy link
Member

@waruqi waruqi commented Jan 26, 2026

@waruqi waruqi added this to the v3.0.7 milestone Jan 26, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors and improves the way header files are identified within the GCC toolchain module. By introducing a dedicated helper function and expanding the list of recognized header extensions, it ensures more robust and comprehensive support for precompiled header (PCH) processing across a wider variety of source file types. This change enhances the build system's flexibility and maintainability.

Highlights

  • Expanded Header File Recognition: The logic for identifying header files has been enhanced to include a broader range of extensions, specifically .ipp, .tcc, .tpl, and .inc, in addition to the previously recognized .h and .inl.
  • Centralized Header Check Logic: A new helper function, _is_header_file, has been introduced to encapsulate and centralize the logic for determining if a given file extension corresponds to a header file.
  • Improved Efficiency with Hashset: The core.base.hashset module is now imported and utilized within the _is_header_file function to efficiently store and check for various header extensions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request refactors the logic for identifying header files into a dedicated function _is_header_file within xmake/modules/core/tools/gcc.lua. This improves code readability and maintainability by centralizing the header file extension checks. The change also correctly imports the hashset module, which is used by the new function.

@luadebug
Copy link
Member

luadebug commented Jan 26, 2026

Thanks :D Would that be convenient to add that project as test as I did in my PR?

@waruqi
Copy link
Member Author

waruqi commented Jan 27, 2026

Thanks :D Would that be convenient to add that project as test as I did in my PR?

I don't think it's necessary to add a separate test project. We can add multiple targets to the existing pch test example to test different extensions.

@waruqi waruqi merged commit efe8fc1 into dev Jan 27, 2026
62 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants