Skip to content

Update tbox to support case#7237

Merged
waruqi merged 2 commits intodevfrom
case
Jan 18, 2026
Merged

Update tbox to support case#7237
waruqi merged 2 commits intodevfrom
case

Conversation

@waruqi
Copy link
Member

@waruqi waruqi commented Jan 18, 2026

  • Before adding new features and new modules, please go to issues to submit the relevant feature description first.
  • Write good commit messages and use the same coding conventions as the rest of the project.
  • Please commit code to dev branch and we will merge into master branch in feature
  • Ensure your edited codes with four spaces instead of TAB.
  • 增加新特性和新模块之前，请先到issues提交相关特性说明，经过讨论评估确认后，再进行相应的代码提交，避免做无用工作。
  • 编写友好可读的提交信息，并使用与工程代码相同的代码规范，代码请用4个空格字符代替tab缩进。
  • 请提交代码到dev分支，如果通过，我们会在特定时间合并到master分支上。
  • 为了规范化提交日志的格式，commit消息，不要用中文，请用英文描述。

@waruqi waruqi added this to the v3.0.7 milestone Jan 18, 2026
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Jan 18, 2026

Summary of Changes

Hello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the tbox library's support for character case manipulation, particularly for wide characters. It involves updating the tbox subproject and modifying platform-specific configuration files to consistently enable standard wide character case conversion functions while phasing out non-standard alternatives. This change aims to improve the robustness and portability of character handling across different operating systems.

Highlights

  • Wide Character Case Conversion: Enabled towlower and towupper functions across various platform configurations to standardize wide character case conversion, improving portability and internationalization support.
  • Deprecated Function Disablement: Disabled less standard or deprecated string and wide string case conversion functions such as strupr, strlwr, wcsupr, and wcslwr in relevant configuration files.
  • Subproject Update: Updated the tbox subproject to a newer commit, reflecting upstream changes and ensuring compatibility with the new case handling configurations.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@waruqi waruqi mentioned this pull request Jan 18, 2026
Merged
gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 18, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the tbox submodule and adds configuration macros for case conversion functions across various platforms. The changes are straightforward, but there are some minor inconsistencies in the commenting style for #undef directives in the Haiku and Solaris configuration files. I've added specific comments to address these for better code consistency. Otherwise, the changes look good.

core/src/tbox/inc/haiku/tbox.config.h
Comment on lines +71 to +72
/*#undef TB_CONFIG_LIBC_HAVE_STRUPR*/
/*#undef TB_CONFIG_LIBC_HAVE_STRLWR*/
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other configuration files in this PR, please add spaces around the #undef directive inside the comment. This improves readability and maintains a uniform style across the project.

Suggested change
/*#undef TB_CONFIG_LIBC_HAVE_STRUPR*/
/*#undef TB_CONFIG_LIBC_HAVE_STRLWR*/
/* #undef TB_CONFIG_LIBC_HAVE_STRUPR */
/* #undef TB_CONFIG_LIBC_HAVE_STRLWR */

core/src/tbox/inc/haiku/tbox.config.h
Comment on lines +91 to +92
/*#undef TB_CONFIG_LIBC_HAVE_WCSUPR*/
/*#undef TB_CONFIG_LIBC_HAVE_WCSLWR*/
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other configuration files in this PR, please add spaces around the #undef directive inside the comment. This improves readability and maintains a uniform style across the project.

Suggested change
/*#undef TB_CONFIG_LIBC_HAVE_WCSUPR*/
/*#undef TB_CONFIG_LIBC_HAVE_WCSLWR*/
/* #undef TB_CONFIG_LIBC_HAVE_WCSUPR */
/* #undef TB_CONFIG_LIBC_HAVE_WCSLWR */

core/src/tbox/inc/solaris/tbox.config.h
Comment on lines +89 to +90
/*#undef TB_CONFIG_LIBC_HAVE_WCSUPR*/
/*#undef TB_CONFIG_LIBC_HAVE_WCSLWR*/
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other configuration files in this PR, please add spaces around the #undef directive inside the comment. This improves readability and maintains a uniform style across the project.

Suggested change
/*#undef TB_CONFIG_LIBC_HAVE_WCSUPR*/
/*#undef TB_CONFIG_LIBC_HAVE_WCSLWR*/
/* #undef TB_CONFIG_LIBC_HAVE_WCSUPR */
/* #undef TB_CONFIG_LIBC_HAVE_WCSLWR */

@waruqi waruqi merged commit e8a618f into dev Jan 18, 2026
71 checks passed
@waruqi waruqi deleted the case branch January 18, 2026 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.0.7

Development

Successfully merging this pull request may close these issues.

1 participant

@waruqi