Skip to content

improve linker.link_scripts#7232

Merged
waruqi merged 1 commit intodevfrom
linker
Jan 17, 2026
Merged

improve linker.link_scripts#7232
waruqi merged 1 commit intodevfrom
linker

Conversation

@waruqi
Copy link
Member

@waruqi waruqi commented Jan 16, 2026

@waruqi waruqi added this to the v3.0.7 milestone Jan 16, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the linker.link_scripts rule within Xmake to fully support the application of multiple linker scripts to a build target. It addresses a limitation where only the initial script was processed, ensuring that all specified linker scripts are now correctly passed to compatible linkers using the -T flag. This change improves the flexibility and correctness of linker script management in Xmake projects.

Highlights

  • Multiple Linker Scripts Support: The linker.link_scripts rule now correctly processes and applies all provided linker scripts to a target, rather than being limited to only the first one found. This is achieved by iterating through all sourcebatch.sourcefiles and applying the -T flag for each script.
  • Improved Script Handling Logic: The logic for checking the presence of linker scripts has been made more robust, ensuring proper handling when no scripts are specified for a target.
  • Refined Linker Tool Detection: The target:has_tool checks have been updated to explicitly include ld in the list of recognized tools, enhancing compatibility for applying linker flags.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves the linker.link_scripts rule by enabling support for multiple linker scripts, which is a feature available in GNU and LLVM linkers. The implementation correctly iterates through all provided linker scripts, adding each with a -T flag. Additionally, the code has been refactored for better clarity and conciseness by removing redundant conditional logic. I have one suggestion to further enhance maintainability by avoiding code duplication.

@waruqi waruqi merged commit 8cd1e81 into dev Jan 17, 2026
69 checks passed
@waruqi waruqi deleted the linker branch January 17, 2026 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant