Skip to content

Improve warnings output#7214

Merged
waruqi merged 2 commits intodevfrom
cl
Jan 14, 2026
Merged

Improve warnings output#7214
waruqi merged 2 commits intodevfrom
cl

Conversation

@waruqi
Copy link
Member

@waruqi waruqi commented Jan 12, 2026

@waruqi waruqi added this to the v3.0.7 milestone Jan 12, 2026
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Jan 12, 2026

Summary of Changes

Hello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing the robustness and correctness of Xmake's build and installation processes. It refactors the warning display mechanism for the CL tool, making it more modular, and significantly improves the handling of library installation paths for CMake and pkgconfig import files. These changes ensure more accurate path resolution, especially for shared libraries and custom installation layouts, and introduce better validation for installed directory structures.

Highlights

  • Refactored CL Warning Handling: Extracted warning display logic in xmake/modules/core/tools/cl.lua into a new _show_warnings function for better modularity and reusability.
  • Improved Include Note Parsing: Introduced a dedicated has_include_note function in xmake/modules/core/tools/cl/parse_include.lua with caching for optimized detection of include notes in compiler output.
  • Standardized CMake Install Paths: Implemented a new _get_install_libdir utility in xmake/modules/target/action/install/cmake_importfiles.lua to consistently determine installation library directories, ensuring proper path resolution and validation.
  • Corrected CMake Shared Library Paths: Fixed an issue in CMake import file generation where IMPORTED_LOCATION for shared libraries on DLL platforms incorrectly pointed to /lib instead of /bin.
  • Enhanced Pkgconfig Path Validation: Added validation in xmake/modules/target/action/install/pkgconfig_importfiles.lua to ensure the resolved libdir for pkgconfig files is always a subdirectory of the installdir.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@waruqi waruqi changed the title Cl Improve warnings output for cl.exe Jan 12, 2026
gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 12, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request significantly improves how warnings from cl.exe are handled by introducing a more robust parsing function, _show_warnings. This new function better handles various warning formats and filters out irrelevant lines from the compiler output. The changes also refactor the include-note parsing logic for better performance and correctness. Additionally, there are some beneficial refactorings in the CMake and pkg-config import file generation logic, which enhance code structure and robustness. I've identified a potential bug in the include-note parsing logic and a minor performance improvement opportunity in the warning display logic, for which I've provided suggestions.

@waruqi waruqi mentioned this pull request Jan 12, 2026
Closed
@waruqi waruqi changed the title Improve warnings output for cl.exe Improve warnings output Jan 13, 2026
@waruqi waruqi merged commit cc4413c into dev Jan 14, 2026
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.0.7

Development

Successfully merging this pull request may close these issues.

1 participant

@waruqi