Skip to content

fix installdir of imporfiles#7213

Merged
waruqi merged 4 commits intodevfrom
importfiles
Jan 12, 2026
Merged

fix installdir of imporfiles#7213
waruqi merged 4 commits intodevfrom
importfiles

Conversation

@waruqi
Copy link
Member

@waruqi waruqi commented Jan 12, 2026

@waruqi waruqi added this to the v3.0.7 milestone Jan 12, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where CMake and pkg-config import files were being generated with incorrect installation directory paths. The changes streamline the process of identifying the correct library installation location and ensure that all related file paths are constructed accurately, which prevents potential problems with consumers failing to locate installed libraries.

Highlights

  • Refactored Library Directory Calculation: Standardized the logic for determining the library installation directory (libdir) within CMake and pkg-config import file generation. This now correctly accounts for explicit opt.libdir (joining it with installdir) or falls back to the target's default library directory (target:libdir()).
  • Corrected Import File Path Construction: Updated the internal functions responsible for generating CMake and pkg-config import files to use the newly standardized libdir for constructing the final destination paths, ensuring accurate placement of these files.
  • Parameter Consistency and Cleanup: Adjusted function signatures and internal calls, such as _get_libfile and _get_builtinvars, to consistently use the libdir parameter where appropriate, removing the redundant installdir parameter from _get_builtinvars.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors how the installation directory for CMake and pkg-config import files is determined, making it more flexible by using target:libdir() as a default. While this improves flexibility, it introduces a potential correctness issue where files might be installed outside the specified installation prefix. I've added comments highlighting this risk and also suggested a refactoring to reduce code duplication for better maintainability.

@waruqi waruqi merged commit 0569f75 into dev Jan 12, 2026
70 checks passed
@waruqi waruqi deleted the importfiles branch January 12, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant