Skip to content

WDK: Add shared directory to KMDF include path#7206

Merged
waruqi merged 1 commit intoxmake-io:devfrom
SuperSodaSea:fix/kmdf-shared
Jan 10, 2026
Merged

WDK: Add shared directory to KMDF include path#7206
waruqi merged 1 commit intoxmake-io:devfrom
SuperSodaSea:fix/kmdf-shared

Conversation

@SuperSodaSea
Copy link
Contributor

@SuperSodaSea SuperSodaSea commented Jan 10, 2026

Fixes #7047.

Test Code

xmake.lua

target("Test")
    add_rules("wdk.env.kmdf", "wdk.driver")
    add_files("Test.c")

Test.c

#include <ntddk.h>
#include <dispmprt.h>

NTSTATUS DriverEntry(PDRIVER_OBJECT driverObject, PUNICODE_STRING registryPath) {
    return STATUS_SUCCESS;
}

Before:

error: Test.c
C:\Program Files (x86)\Windows Kits\10\Include\10.0.22621.0\km\dispmprt.h(25): fatal error C1083: 无法打开包括文件: “acpiioct.h”: No such file or directory

After:

(No error)

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Jan 10, 2026

Summary of Changes

Hello @SuperSodaSea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request provides a crucial fix for Windows Driver Kit (WDK) kernel-mode driver framework (KMDF) projects managed by xmake. It resolves a common compilation error where essential header files, specifically those located in the WDK's shared directory, were not being found. By explicitly adding this directory to the system include paths for KMDF builds, the change ensures that drivers can correctly resolve dependencies like acpiioct.h, thereby enabling successful compilation and preventing build failures.

Highlights

  • Fixes Build Error: Addresses issue WDM driver builds should include 'shared' WDK header directory #7047 by resolving a fatal error C1083 related to missing include files in KMDF driver projects.
  • Adds Shared Include Path: Integrates the WDK shared directory into the KMDF build system's include paths.
  • Enables dispmprt.h Usage: Allows successful compilation of KMDF drivers that include dispmprt.h, which indirectly requires acpiioct.h from the shared directory.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 10, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request correctly fixes the build issue for KMDF drivers by adding the 'shared' WDK include directory. The change is simple and effective. I've also included a suggestion to refactor the related code to improve maintainability by removing some redundancy. This suggestion is optional and not a blocker for this pull request.

@waruqi waruqi merged commit baf6ad2 into xmake-io:dev Jan 10, 2026
38 checks passed
@waruqi waruqi added this to the v3.0.7 milestone Jan 10, 2026
@SuperSodaSea SuperSodaSea deleted the fix/kmdf-shared branch January 10, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.0.7

Development

Successfully merging this pull request may close these issues.

WDM driver builds should include 'shared' WDK header directory

2 participants

@SuperSodaSea @waruqi