Conversation
waruqi
commented
Jan 9, 2026
- Before adding new features and new modules, please go to issues to submit the relevant feature description first.
- Write good commit messages and use the same coding conventions as the rest of the project.
- Please commit code to dev branch and we will merge into master branch in feature
- Ensure your edited codes with four spaces instead of TAB.
- 增加新特性和新模块之前，请先到issues提交相关特性说明，经过讨论评估确认后，再进行相应的代码提交，避免做无用工作。
- 编写友好可读的提交信息，并使用与工程代码相同的代码规范，代码请用4个空格字符代替tab缩进。
- 请提交代码到dev分支，如果通过，我们会在特定时间合并到master分支上。
- 为了规范化提交日志的格式，commit消息，不要用中文，请用英文描述。
Summary of ChangesHello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the MinGW toolchain detection and configuration within Xmake. The primary goal is to standardize how target architecture information is handled, ensuring it's explicitly passed and utilized throughout the detection process. This change improves the flexibility and accuracy of MinGW toolchain identification, particularly for cross-compilation scenarios, by centralizing architecture-related logic and simplifying function parameter handling. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request improves the MinGW toolchain detection by making it architecture-aware. The changes refactor how the cross prefix and arch are determined, allowing the architecture to be derived from the cross-compiler prefix, which is a great enhancement for cross-compilation scenarios. The code is cleaner and more extensible. I've added a couple of suggestions to further improve the maintainability of the new logic by using data-driven approaches instead of long if/elseif chains.
| if toolchain:is_arch("x86_64", "x64") then | ||
| cross = "x86_64-w64-mingw32-" | ||
| elseif toolchain:is_arch("i386", "x86", "i686") then | ||
| cross = "i686-w64-mingw32-" | ||
| elseif toolchain:is_arch("arm64", "aarch64") then | ||
| cross = "aarch64-w64-mingw32-" | ||
| elseif toolchain:is_arch("armv7", "arm.*") then | ||
| cross = "armv7-w64-mingw32-" | ||
| end |
There was a problem hiding this comment.
This if/elseif chain for determining the cross prefix from the architecture can be refactored into a loop over a configuration table. This would make the code more data-driven, easier to read, and more maintainable, especially if more architectures are supported in the future.
local arch_to_cross_map = {
{cross = "x86_64-w64-mingw32-", archs = {"x86_64", "x64"}},
{cross = "i686-w64-mingw32-", archs = {"i386", "x86", "i686"}},
{cross = "aarch64-w64-mingw32-", archs = {"arm64", "aarch64"}},
{cross = "armv7-w64-mingw32-", archs = {"armv7", "arm.*"}}
}
for _, mapping in ipairs(arch_to_cross_map) do
if toolchain:is_arch(table.unpack(mapping.archs)) then
cross = mapping.cross
break
end
end