Conversation
Summary of ChangesHello @veritas-Qiu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求通过修改 Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
本次 PR 为 CUDA 架构版本号添加了后缀支持（例如 'a' 和 'f'），使其能够处理像 sm_90a 这样的架构。代码通过正则表达式解析版本号和后缀，并添加了对后缀有效性的检查。这是一个很好的改进。
然而，我发现了一个严重问题：新的实现在 parse_arch 函数中返回字符串（当存在后缀时），而之前它总是返回数字。这会导致在 nf_cugencode 函数中调用 math.min 时崩溃，因为它无法处理字符串。我在代码中留下了详细的审查意见。请务必修复此问题以避免运行时错误。
#6910 的work around方案，手动更新数字列表而不是自动获取，但增加后缀支持
关于后缀支持，可以参考NVCC doc
注意：改动前，xmake支持非标准连接符号（如sm-90 sm@90等），改动后，将只支持下划线和无连接符号（sm_90和sm90）