Skip to content

improve clang-cl depfiles #7070#7136

Merged
waruqi merged 3 commits intodevfrom
clangcl
Dec 15, 2025
Merged

improve clang-cl depfiles #7070#7136
waruqi merged 3 commits intodevfrom
clangcl

Conversation

@waruqi
Copy link
Member

@waruqi waruqi commented Dec 15, 2025

@waruqi waruqi added this to the v3.0.6 milestone Dec 15, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the dependency tracking mechanism for clang-cl within the xmake build system. It introduces an intelligent detection for clang-cl's native dependency generation capabilities, allowing xmake to leverage the more efficient /clang:-MMD -MF flags when available. This enhancement aims to improve the accuracy and robustness of build dependency management for projects using clang-cl by adapting to the compiler's specific features.

Highlights

  • Clang-cl Dependency File Detection: Implemented a new helper function, _has_clang_mmd, to dynamically check if the clang-cl compiler supports the /clang:-MMD -MF flags for generating dependency files.
  • Conditional Dependency Generation: Modified the compile function to conditionally use the /clang:-MMD -MF flags (which produce GCC-style dependency files) if supported by clang-cl. If not supported, it falls back to the existing -showIncludes method (CL-style dependency files).
  • Temporary Depfile Cleanup: Added logic to ensure that any temporary dependency files created using the /clang:-MMD -MF flags are properly removed after compilation, preventing file leakage.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves dependency file generation for clang-cl by detecting and using the -MMD -MF flags, which is a more robust method than parsing -showIncludes output. The implementation is mostly correct, but I've found a couple of areas for improvement. There's a logic simplification possible in the feature detection function, and more importantly, a potential silent failure in dependency tracking if the dependency file is not generated as expected. I've provided suggestions to address these points.

@waruqi waruqi merged commit d3acb6c into dev Dec 15, 2025
68 checks passed
@waruqi waruqi deleted the clangcl branch December 15, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant