Skip to content

Fix clang-cl toolchain with asan#7132

Merged
waruqi merged 1 commit intoxmake-io:devfrom
star-hengxing:patch-1
Dec 14, 2025
Merged

Fix clang-cl toolchain with asan#7132
waruqi merged 1 commit intoxmake-io:devfrom
star-hengxing:patch-1

Conversation

@star-hengxing
Copy link
Contributor

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @star-hengxing, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where the clang-cl toolchain did not correctly integrate with AddressSanitizer. By introducing a conditional configuration that sets the appropriate linker and archiver tools (clang++ and llvm-ar) when ASan is active, this change ensures that projects using clang-cl can now successfully build and utilize AddressSanitizer for memory error detection.

Highlights

  • AddressSanitizer (ASan) Support: The clang-cl toolchain has been updated to correctly configure its linker and archiver when AddressSanitizer is enabled. Specifically, it now uses clang++ for linking and llvm-ar for archiving, resolving compatibility issues that prevented ASan from working properly with clang-cl.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request modifies the clang-cl toolchain configuration in xmake/toolchains/clang-cl/load.lua to specifically set the linker (ld, sh) to clang++ and the archiver (ar) to llvm-ar when the build.sanitizer.address project policy is enabled. There were no review comments provided.

@waruqi waruqi merged commit c078b92 into xmake-io:dev Dec 14, 2025
31 of 35 checks passed
@waruqi waruqi added this to the v3.0.6 milestone Dec 14, 2025
@star-hengxing star-hengxing deleted the patch-1 branch December 14, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants