Conversation
waruqi
commented
Dec 2, 2025
- Before adding new features and new modules, please go to issues to submit the relevant feature description first.
- Write good commit messages and use the same coding conventions as the rest of the project.
- Please commit code to dev branch and we will merge into master branch in feature
- Ensure your edited codes with four spaces instead of TAB.
- 增加新特性和新模块之前，请先到issues提交相关特性说明，经过讨论评估确认后，再进行相应的代码提交，避免做无用工作。
- 编写友好可读的提交信息，并使用与工程代码相同的代码规范，代码请用4个空格字符代替tab缩进。
- 请提交代码到dev分支，如果通过，我们会在特定时间合并到master分支上。
- 为了规范化提交日志的格式，commit消息，不要用中文，请用英文描述。
Summary of ChangesHello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses and resolves build failures encountered on the Solaris platform. It achieves this by introducing platform-specific compiler definitions in the build scripts ( Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to fix the build on the Solaris platform by updating the tbox submodule and adding necessary feature test macros to the build scripts. The changes correctly identify the need for _POSIX_C_SOURCE and _XOPEN_SOURCE to enable functions like setenv and clock_gettime on Solaris.
My review focuses on a small simplification. The definition of _XOPEN_SOURCE=600 makes the explicit definition of _POSIX_C_SOURCE=200112L redundant. I've suggested removing the redundant macro in both xmake.lua and xmake.sh to make the configuration cleaner.
core/xmake.lua
Outdated
|
|
||
| -- ensure POSIX/XOPEN features are available on Solaris (for setenv, unsetenv, clock_gettime, etc.) | ||
| if is_plat("solaris") then | ||
| add_defines("_POSIX_C_SOURCE=200112L", "_XOPEN_SOURCE=600") |
There was a problem hiding this comment.
The _POSIX_C_SOURCE=200112L define is redundant when _XOPEN_SOURCE=600 is also defined. According to POSIX standards and Solaris documentation, defining _XOPEN_SOURCE=600 implicitly sets _POSIX_C_SOURCE to 200112L. You can simplify this by only defining _XOPEN_SOURCE=600.
add_defines("_XOPEN_SOURCE=600")
core/xmake.sh
Outdated
|
|
||
| # ensure POSIX/XOPEN features are available on Solaris (for setenv, unsetenv, clock_gettime, etc.) | ||
| if is_plat "solaris"; then | ||
| add_defines "_POSIX_C_SOURCE=200112L" "_XOPEN_SOURCE=600" |
There was a problem hiding this comment.
The _POSIX_C_SOURCE=200112L define is redundant when _XOPEN_SOURCE=600 is also defined. According to POSIX standards and Solaris documentation, defining _XOPEN_SOURCE=600 implicitly sets _POSIX_C_SOURCE to 200112L. You can simplify this by only defining _XOPEN_SOURCE=600.
| add_defines "_POSIX_C_SOURCE=200112L" "_XOPEN_SOURCE=600" | |
| add_defines "_XOPEN_SOURCE=600" |
50c3dc4 to
408fd67
Compare