Conversation
Summary of ChangesHello @choyy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the reliability of package version detection for Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request addresses an issue with pacman package version retrieval, particularly when a package contains multiple .pc files. The previous logic of deriving the version from pcresult.version has been removed, and a new approach is introduced to query the version directly from pacman -Q <package_name>. This change aims to ensure more accurate version reporting. However, the new version parsing logic has a couple of issues that need to be addressed to prevent incorrect version numbers and potential runtime errors.
| local version = try { function() return os.iorunv(pacman.program, {"-Q", name}) end } | ||
| version = version:trim():split('%s+')[2] | ||
| result.version = version:split('-')[1] |
There was a problem hiding this comment.
The new version parsing logic does not handle package versions that include an epoch, such as 1:1.3.204-1. The _find_package_from_list function (lines 107-109) correctly strips this prefix. Without this, the result.version might be 1:1.3.204 instead of 1.3.204.
Additionally, the version variable might be nil if os.iorunv fails to return any output. Directly calling trim() or split() on a nil value will cause a runtime error. It's important to check if version is valid before attempting string operations on it.
local version = try { function() return os.iorunv(pacman.program, {"-Q", name}) end }
if version then
version = version:trim():split('%s+')[2]
-- we need strip "1:" prefix, @see https://github.com/xmake-io/xmake/issues/2020
-- e.g. vulkan-headers 1:1.3.204-1
if version:startswith("1:") then
version = version:split(':')[2]
end
result.version = version:split('-')[1]
end
ba690c3 to
20cdfc4
Compare
| if verstr then | ||
| local version = semver.match(verstr) | ||
| if version then | ||
| result.version = version:rawstr():split('-')[1] |
There was a problem hiding this comment.
Why do not use version:rawstr()? it's already a valid semver.
There was a problem hiding this comment.
pacman version is pkgver-pkgrel, split('-')[1] is to remove pkgrel to get the original version.
No description provided.