Skip to content

Add support for cuda 11~13; update templates and examples#7083

Merged
waruqi merged 1 commit intoxmake-io:devfrom
OpportunityLiu:feat-cuda
Dec 1, 2025
Merged

Add support for cuda 11~13; update templates and examples#7083
waruqi merged 1 commit intoxmake-io:devfrom
OpportunityLiu:feat-cuda

Conversation

@OpportunityLiu
Copy link
Member

  • Before adding new features and new modules, please go to issues to submit the relevant feature description first.
  • Write good commit messages and use the same coding conventions as the rest of the project.
  • Please commit code to dev branch and we will merge into master branch in feature
  • Ensure your edited codes with four spaces instead of TAB.

  • 增加新特性和新模块之前,请先到issues提交相关特性说明,经过讨论评估确认后,再进行相应的代码提交,避免做无用工作。
  • 编写友好可读的提交信息,并使用与工程代码相同的代码规范,代码请用4个空格字符代替tab缩进。
  • 请提交代码到dev分支,如果通过,我们会在特定时间合并到master分支上。
  • 为了规范化提交日志的格式,commit消息,不要用中文,请用英文描述。

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @OpportunityLiu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly upgrades the project's CUDA integration to support newer CUDA versions (11-13) and their corresponding GPU architectures. It involves updating the recognized compute capabilities, SASS generation targets, and device detection mechanisms across various parts of the codebase, including documentation, test configurations, and project templates, to ensure forward compatibility and leverage modern NVIDIA hardware features.

Highlights

  • Expanded CUDA Architecture Support: The build system now recognizes and supports a wider range of CUDA virtual and real architectures, extending up to sm_121 and compute_121, ensuring compatibility with the latest NVIDIA GPUs.
  • Updated Default Compute Capabilities: Documentation examples, test projects, and project templates have been updated to use more modern default CUDA compute capabilities, primarily compute_75 and compute_100, reflecting current hardware standards.
  • Enhanced CUDA Device Detection: The logic for detecting and ordering CUDA devices by FLOPs has been improved by incorporating core counts for newer SM architectures, leading to more accurate hardware assessment.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates CUDA support across the project, introducing compatibility for newer architectures and future-proofing for upcoming CUDA versions, likely up to version 13. The changes are consistently applied to documentation, test projects, and templates, with default compute capabilities being updated to more modern standards. My review found the changes to be well-aligned with the PR's objectives. I have one suggestion in xmake/rules/cuda/gencodes/xmake.lua to improve code maintainability by addressing duplicated code.

@waruqi waruqi merged commit e683397 into xmake-io:dev Dec 1, 2025
33 checks passed
@waruqi waruqi added this to the v3.0.6 milestone Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants