Save QT rules for llvm-toolchain#7069
Conversation
Summary of ChangesHello @MaxwellGengYF, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the application of specific C++ compiler flags within the XMake QT rules. It ensures that certain flags, previously applied broadly on Windows for QT 6.0+, are now conditionally applied only when using Microsoft's Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
xmake/rules/qt/load.lua
Outdated
| @@ -225,8 +225,8 @@ function main(target, opt) | |||
| if qt_sdkver:ge("6.0") then | |||
| -- @see https://github.com/xmake-io/xmake/issues/2071 | |||
| if target:is_plat("windows") then | |||
There was a problem hiding this comment.
直接判断就行了。
if target:is_plat("windows") and target:has_tool("cxx", "clang_cl", "cl") thenThere was a problem hiding this comment.
Code Review
This pull request correctly restricts the MSVC-specific compiler flags /Zc:__cplusplus and /permissive- to cl.exe and clang-cl.exe when building Qt projects on Windows. This prevents issues when using other toolchains like MinGW/GCC on Windows. The change is logical and well-implemented. I have one suggestion to make the code slightly more concise by combining the two target:add calls into a single one.
xmake/rules/qt/load.lua
Outdated
| target:add("cxxflags", "/Zc:__cplusplus", { tools = {"clang_cl", "cl"} }) | ||
| target:add("cxxflags", "/permissive-", { tools = {"clang_cl", "cl"} }) |
There was a problem hiding this comment.
For conciseness, you can combine these two target:add calls into a single call. The target:add function supports adding multiple values at once.
target:add("cxxflags", "/Zc:__cplusplus", "/permissive-", { tools = {"clang_cl", "cl"} })
These cxx-flags is only for cl.exe and clang_cl.exe