Conversation
waruqi
commented
Nov 22, 2025
- Before adding new features and new modules, please go to issues to submit the relevant feature description first.
- Write good commit messages and use the same coding conventions as the rest of the project.
- Please commit code to dev branch and we will merge into master branch in feature
- Ensure your edited codes with four spaces instead of TAB.
- 增加新特性和新模块之前，请先到issues提交相关特性说明，经过讨论评估确认后，再进行相应的代码提交，避免做无用工作。
- 编写友好可读的提交信息，并使用与工程代码相同的代码规范，代码请用4个空格字符代替tab缩进。
- 请提交代码到dev分支，如果通过，我们会在特定时间合并到master分支上。
- 为了规范化提交日志的格式，commit消息，不要用中文，请用英文描述。
Summary of ChangesHello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the build system's compatibility and detection capabilities across various operating systems, with a particular focus on expanding support for different BSD variants and Solaris. It refines how the system identifies operating systems and architectures, and adjusts linking configurations accordingly. Additionally, it includes an update to a core subproject and conditional test exclusions for BSD platforms to ensure stability. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request extends support for several BSD variants (NetBSD, OpenBSD, DragonflyBSD) and Solaris. The changes are generally well-implemented across the build scripts. However, I've identified a critical bug in the configure script related to architecture detection for i86pc, which is common on Solaris. The current implementation will not work as intended. I have provided a specific comment and a code suggestion to fix this issue. The other changes, including disabling some tests on BSD platforms, appear to be reasonable.
configure
Outdated
| if test_eq "${os_arch}" "i686" "i86pc"; then | ||
| os_arch="i386" |
There was a problem hiding this comment.
The test_eq function only compares the first two arguments it receives. The third argument, "i86pc", is being ignored. This means the condition will only be true for i686 and will fail for i86pc, breaking architecture detection on systems like Solaris x86. To correctly check for either architecture, you should use a logical OR || to combine two separate calls to test_eq.
| if test_eq "${os_arch}" "i686" "i86pc"; then | |
| os_arch="i386" | |
| if test_eq "${os_arch}" "i686" || test_eq "${os_arch}" "i86pc"; then | |
| os_arch="i386" |