Conversation
waruqi
commented
Nov 15, 2025
- Before adding new features and new modules, please go to issues to submit the relevant feature description first.
- Write good commit messages and use the same coding conventions as the rest of the project.
- Please commit code to dev branch and we will merge into master branch in feature
- Ensure your edited codes with four spaces instead of TAB.
- 增加新特性和新模块之前，请先到issues提交相关特性说明，经过讨论评估确认后，再进行相应的代码提交，避免做无用工作。
- 编写友好可读的提交信息，并使用与工程代码相同的代码规范，代码请用4个空格字符代替tab缩进。
- 请提交代码到dev分支，如果通过，我们会在特定时间合并到master分支上。
- 为了规范化提交日志的格式，commit消息，不要用中文，请用英文描述。
Summary of ChangesHello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the core graph library by introducing explicit edge removal and refining vertex removal, alongside optimizing graph cloning and reversal operations. Furthermore, it introduces a sophisticated "bridge node" system within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces significant improvements to the graph and jobgraph modules. In graph.lua, the addition of remove_edge and remove_vertex functions, along with the refactoring of clone and reverse, enhances functionality, correctness, and code clarity. The new implementations are more robust and efficient. In jobgraph.lua, the concept of "bridge nodes" for managing dependencies between job groups is refined, making group dependencies reusable and correctly handling dynamic job additions. New tests have been added to cover these new features, ensuring their correctness. The overall quality of the changes is high, and I have one suggestion to improve the code's robustness.
xmake/core/base/graph.lua
Outdated
| if not target_edge then | ||
| return | ||
| end |
There was a problem hiding this comment.
This check for target_edge is redundant. The function already checks self:has_edge(from, to) at the beginning (line 401). If has_edge returns true, a target_edge should always be found in the preceding loop. If it's not found, it indicates an inconsistency in the graph's internal state (e.g., _edges_map is out of sync with _edges), which is a bug that should not be silently ignored by returning here. Removing this check would make the code cleaner and help surface such potential bugs earlier.