Skip to content

Make zig-cc inherit from clang#7022

Merged
waruqi merged 2 commits intoxmake-io:devfrom
moegodot:dev
Nov 14, 2025
Merged

Make zig-cc inherit from clang#7022
waruqi merged 2 commits intoxmake-io:devfrom
moegodot:dev

Conversation

@moegodot
Copy link
Contributor

@moegodot moegodot commented Nov 13, 2025

根据zig作者andrewkelley的说法，zig cc使用的编译参数和clang相同（其实就是调LLVM的包）

https://andrewkelley.me/post/zig-cc-powerful-drop-in-replacement-gcc-clang.html

所以zig cc的配置inherit from clang或许更合理

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Nov 13, 2025

Summary of Changes

Hello @moegodot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求旨在优化 xmake 中 zig cc 工具链的集成配置。通过将 zig cc 的继承关系从 gcc 调整为 clang，我们确保了 xmake 能够更精确地处理 zig cc 的编译参数，从而提升了工具链的兼容性和正确性，使其与 zig 官方推荐的使用方式保持一致。

Highlights

  • zig cc 工具链配置更新: 将 zig cc 工具链的继承配置从 gcc 更改为 clang，以更准确地反映其底层编译参数与 clang 的一致性。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 13, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

这个PR的修改是正确的。根据Zig官方的说法，zig cc 是 clang 的一个封装，因此让 zig_cc 工具链继承自 clang 是合理的，这能让它获得更匹配 clang 的编译和链接选项。我还提供了一个小的建议来更新代码注释，以保持代码的清晰和一致。

@waruqi waruqi added this to the v3.0.5 milestone Nov 14, 2025
@waruqi waruqi merged commit 7b66ccf into xmake-io:dev Nov 14, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.0.5

Development

Successfully merging this pull request may close these issues.

2 participants

@moegodot @waruqi