Conversation
Summary of ChangesHello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue related to project default configurations within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the logic for resetting project configurations and caches into a new utility function vsutils.reset_config_and_caches, which is a good improvement to reduce code duplication. However, there is a critical issue in the implementation: the new function uses mode and arch variables that are not in its scope, which will lead to incorrect behavior. These variables need to be passed as arguments to the function. I've provided specific comments and suggestions to fix this.
| return (filepath:gsub("::", "#")) | ||
| end | ||
|
|
||
| function reset_config_and_caches() |
There was a problem hiding this comment.
The variables mode and arch used on lines 71 and 72 are not defined within the scope of this function. They will be nil, which is not the intended behavior as it would incorrectly reset the mode and architecture. To fix this, you should pass mode and arch as arguments to this function.
function reset_config_and_caches(mode, arch)
| localcache.clear("toolchain") | ||
| localcache.clear("cxxmodules") | ||
| -- reset project configs and caches | ||
| vsutils.reset_config_and_caches() |
There was a problem hiding this comment.
You need to pass the mode and arch variables to the reset_config_and_caches function. The mode and arch variables are local to the loops in the make function and are not accessible inside reset_config_and_caches otherwise.
vsutils.reset_config_and_caches(mode, arch)
| localcache.clear("toolchain") | ||
| localcache.clear("cxxmodules") | ||
| -- reset project configs and caches | ||
| vsutils.reset_config_and_caches() |
There was a problem hiding this comment.
You need to pass the mode and arch variables to the reset_config_and_caches function. The mode and arch variables are local to the loops in the main function and are not accessible inside reset_config_and_caches otherwise.
vsutils.reset_config_and_caches(mode, arch)
#7014