Skip to content

format code#7008

Merged
waruqi merged 11 commits intodevfrom
format
Nov 9, 2025
Merged

format code#7008
waruqi merged 11 commits intodevfrom
format

Conversation

@waruqi
Copy link
Member

@waruqi waruqi commented Nov 9, 2025

  • Before adding new features and new modules, please go to issues to submit the relevant feature description first.
  • Write good commit messages and use the same coding conventions as the rest of the project.
  • Please commit code to dev branch and we will merge into master branch in feature
  • Ensure your edited codes with four spaces instead of TAB.

  • 增加新特性和新模块之前,请先到issues提交相关特性说明,经过讨论评估确认后,再进行相应的代码提交,避免做无用工作。
  • 编写友好可读的提交信息,并使用与工程代码相同的代码规范,代码请用4个空格字符代替tab缩进。
  • 请提交代码到dev分支,如果通过,我们会在特定时间合并到master分支上。
  • 为了规范化提交日志的格式,commit消息,不要用中文,请用英文描述。

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on applying a comprehensive code formatting standard across the codebase, driven by an updated .clang-format configuration. The changes aim to enhance code consistency, readability, and maintainability, making it easier for developers to navigate and contribute to the project. It touches a wide range of C source files, ensuring a uniform style throughout the core modules.

Highlights

  • Clang-Format Configuration Update: The .clang-format file has been extensively updated to enforce a consistent coding style. Key changes include setting BasedOnStyle: LLVM, explicitly defining indentation with 4 spaces, attaching braces (BreakBeforeBraces: Attach), and adjusting various alignment, spacing, line breaking, and penalty settings to improve code readability and maintainability.
  • Code Formatting Across Core Modules: Numerous C source files across base64, bloom_filter, curses, engine, fwatcher, hash, io, libc, os, package, process, readline, sandbox, semver, string, thread, tty, and winos modules have been reformatted. This includes consistent spacing around macro definitions, standardizing function signatures (e.g., lua_State* lua to lua_State *lua), placing opening braces on the same line for conditional blocks, and consistent pointer casting. Trailing blank lines in header files have also been removed.
  • Improved Macro Readability: Multi-line macro definitions in core/src/xmake/curses/curses.c have been refactored to use \ for line continuation and align braces, enhancing their readability and adherence to the new formatting rules.
  • Windows-Specific Code Page Handling: In core/src/xmake/winos/ansi.c, the xm_expand_cp function now correctly handles CP_OEMCP and CP_ACP for expanding code page values, ensuring proper character encoding management on Windows.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new, more consistent code formatting style by updating the .clang-format configuration and applying it across the codebase. The changes significantly improve code readability and maintainability. The new formatting rules are well-defined and follow modern best practices. I have reviewed the extensive formatting changes across all files and found them to be correctly and consistently applied. This is an excellent contribution to the project's code quality.

@waruqi waruqi merged commit 2b01e46 into dev Nov 9, 2025
43 of 44 checks passed
@waruqi waruqi deleted the format branch November 9, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant