Conversation
waruqi
commented
Nov 7, 2025
- Before adding new features and new modules, please go to issues to submit the relevant feature description first.
- Write good commit messages and use the same coding conventions as the rest of the project.
- Please commit code to dev branch and we will merge into master branch in feature
- Ensure your edited codes with four spaces instead of TAB.
- 增加新特性和新模块之前，请先到issues提交相关特性说明，经过讨论评估确认后，再进行相应的代码提交，避免做无用工作。
- 编写友好可读的提交信息，并使用与工程代码相同的代码规范，代码请用4个空格字符代替tab缩进。
- 请提交代码到dev分支，如果通过，我们会在特定时间合并到master分支上。
- 为了规范化提交日志的格式，commit消息，不要用中文，请用英文描述。
Summary of ChangesHello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the mechanism for retrieving build environment variables within Xmake's package configuration system. It introduces a more granular control over which configuration values are included, preventing the indiscriminate collection of all available settings and focusing on essential, built-in flags. This enhancement aims to improve the precision and efficiency of build environment setup for packages. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly limits the retrieval of build environments from package configurations to a predefined set of built-in configurations. The logic change is sound and addresses the intended issue. I have one suggestion to improve the readability of the new code block by using distinct variable names instead of reusing the value variable, which would make the code easier to understand and maintain.
| local value = config.get(key) | ||
| if value == nil then | ||
| value = self:tool(key) | ||
| end | ||
| value = table.unique(table.join(table.wrap(value), table.wrap(self:config(key)), self:toolconfig(key))) | ||
| if #value > 0 then | ||
| value = table.unwrap(value) | ||
| rawset(tbl, key, value) | ||
| return value | ||
| if value then | ||
| table.join2(result, value) | ||
| end | ||
| -- we can only get the builtin config values | ||
| -- https://github.com/xmake-io/xmake/issues/6897 | ||
| if builtin_configs:has(key) then | ||
| value = self:config(key) | ||
| if value then | ||
| table.join2(result, value) | ||
| end | ||
| end | ||
| value = self:toolconfig(key) | ||
| if value then | ||
| table.join2(result, value) | ||
| end |
There was a problem hiding this comment.
The logic here is correct, but the repeated reuse of the value variable for different purposes (config.get, self:tool, self:config, self:toolconfig) makes the code a bit hard to follow. Using distinct variable names for each value source would improve readability and maintainability.
local value = config.get(key) or self:tool(key)
if value then
table.join2(result, value)
end
-- we can only get the builtin config values
-- https://github.com/xmake-io/xmake/issues/6897
if builtin_configs:has(key) then
local config_value = self:config(key)
if config_value then
table.join2(result, config_value)
end
end
local toolconfig_value = self:toolconfig(key)
if toolconfig_value then
table.join2(result, toolconfig_value)
end