fix(asn1c): include generated output as system headers#7002
fix(asn1c): include generated output as system headers#7002waruqi merged 1 commit intoxmake-io:devfrom
Conversation
Prevents clang-tidy from reporting lint errors in them.
Summary of ChangesHello @gibbz00, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The change to use sysincludedirs instead of includedirs is correct for preventing lint errors in generated code. However, I've identified a significant performance issue in the rule's implementation. The current logic will cause repeated compilations of generated files if a target includes multiple .asn1 files. I've provided a detailed comment with a suggested refactoring to address this.
Prevents clang-tidy from reporting lint errors in them.