Conversation
Summary of ChangesHello @Arthapz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on stabilizing and expanding xmake's support for C++ modules. It introduces new, dedicated test suites to thoroughly verify module compilation and dependency resolution. Concurrently, it refines the internal mechanisms for managing module build dependencies and caching, addressing potential issues that could arise during complex build scenarios. Furthermore, the changes enhance the system's ability to correctly identify and configure C++ standard libraries across a wider range of platforms and toolchains, contributing to more robust and reliable C++ module builds. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request effectively addresses the issue of incorrect dependency handling for C++ modules during xmake test runs. The main fixes involve clearing cached job dependencies and ensuring that dependencies are only considered if they are part of the current build graph. These changes prevent unnecessary rebuilds and fix the test execution flow. The addition of new test cases is a great way to verify the fix and prevent future regressions. I've found one critical issue where undefined variables are used, which will cause a runtime error. I've also pointed out some opportunities for code cleanup by removing dead code and leftover debugging comments.
| if jobgraph:has(dependent_job) then | ||
| jobdeps[dependent_job] = jobdeps[dependent_job] or {} | ||
| table.insert(jobdeps[dependent_job], buildfilejob) | ||
| end |
There was a problem hiding this comment.
This check is a crucial part of the fix. By ensuring a dependent_job exists in the current jobgraph before adding it as a dependency, you correctly isolate the test build's dependency graph from the main build graph. This prevents xmake test from incorrectly flagging dependencies that aren't relevant to the test, which was causing the unnecessary rebuilds. Great fix!
| if sourcebatch_scanner then | ||
| sourcebatch_scanner.sourcefiles = {} | ||
| end | ||
| support.memcache():set2(target:fullname(), "jobdeps", nil) |
There was a problem hiding this comment.
Clearing the jobdeps from the memcache in after_scan is the core of the fix for the reported issue. This correctly ensures that stale dependency information from a previous build does not interfere with a subsequent xmake test run. This is a solid improvement.
b1e8873 to
af23147
Compare
af23147 to
ce72389
Compare
fixes #6991