Skip to content

improve(tty): support detect ghostty#6987

Merged
waruqi merged 1 commit intoxmake-io:devfrom
apocelipes:feat-ghostty
Nov 3, 2025
Merged

improve(tty): support detect ghostty#6987
waruqi merged 1 commit intoxmake-io:devfrom
apocelipes:feat-ghostty

Conversation

@apocelipes
Copy link
Contributor

@apocelipes apocelipes commented Nov 2, 2025

Xmake currently reports ghostty as xterm:

-- test.lua
import("core.base.tty")

print(tty.term())
image

This isn't a big deal, since ghostty is fully compatible with xterm. However, we can do better to detect the ghostty by using environment variables:

image image

After this patch:

image

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Nov 2, 2025

Summary of Changes

Hello @apocelipes, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances Xmake's terminal detection capabilities by introducing explicit support for the 'ghostty' terminal emulator. Previously identified as 'xterm' due to compatibility, this change allows Xmake to accurately recognize 'ghostty' through environment variables, improving the precision of terminal identification within the system.

Highlights

  • Ghostty Detection: Implemented specific detection logic for the 'ghostty' terminal emulator by checking both "TERM_PROGRAM" and "TERM" environment variables.
  • Prioritized Detection: Ensured that 'ghostty' is detected before 'xterm' when parsing the "TERM" environment variable to provide more accurate terminal identification.
  • Documentation Update: Updated the internal documentation in "tty.lua" to include 'ghostty' in the list of supported terminals.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 2, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for detecting the ghostty terminal by checking the TERM_PROGRAM and TERM environment variables. The changes are logical and correctly integrated into the existing detection mechanism. I have one suggestion to improve the robustness of the detection logic.

@waruqi waruqi added this to the v3.0.5 milestone Nov 3, 2025
@waruqi waruqi merged commit ef23205 into xmake-io:dev Nov 3, 2025
21 of 22 checks passed
@apocelipes apocelipes deleted the feat-ghostty branch November 3, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.0.5

Development

Successfully merging this pull request may close these issues.

2 participants

@apocelipes @waruqi