Skip to content

Fix modules support for vsxmake/vs generators#6954

Merged
waruqi merged 4 commits intodevfrom
vsxmake
Oct 21, 2025
Merged

Fix modules support for vsxmake/vs generators#6954
waruqi merged 4 commits intodevfrom
vsxmake

Conversation

@waruqi
Copy link
Member

@waruqi waruqi commented Oct 21, 2025

@waruqi waruqi added this to the v3.0.5 milestone Oct 21, 2025
@waruqi waruqi mentioned this pull request Oct 21, 2025
Closed
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Oct 21, 2025

Summary of Changes

Hello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue with module support in vsxmake and vs generators by refactoring the target toolchain checking mechanism. The core logic for validating toolchains has been moved into a dedicated utility module, private.utils.target, and is now invoked consistently across the main configuration action and the Visual Studio project generation plugins. This ensures that toolchain checks are properly applied, leading to more robust and reliable project generation for Visual Studio environments.

Highlights

  • Centralized Toolchain Checking: The _check_target_toolchains function has been extracted from xmake/actions/config/main.lua and moved into a new, shared utility module located at xmake/modules/private/utils/target.lua.
  • Improved Module Support for VS Generators: The newly centralized target_utils.check_target_toolchains function is now explicitly called in xmake/actions/config/main.lua, xmake/plugins/project/vstudio/impl/vs201x.lua, and xmake/plugins/project/vsxmake/getinfo.lua, ensuring consistent and correct toolchain validation for Visual Studio project generators.
  • Code Refactoring: This change refactors the toolchain validation logic, promoting code reuse and maintainability by consolidating it into a single, accessible utility function.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 21, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the xmake build system to improve module support for vsxmake/vs generators. It introduces a new target_utils module to encapsulate target-related utility functions, specifically the check_target_toolchains function, and integrates it into the configuration and project generation processes. The code changes aim to enhance code modularity and maintainability by moving the toolchain checking logic into a dedicated module. There are a few comments related to moving code around, and ensuring that the moved code is removed from the original location.

@waruqi waruqi merged commit 241acfc into dev Oct 21, 2025
45 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.0.5

Development

Successfully merging this pull request may close these issues.

1 participant

@waruqi