Enhance Clang toolchain with LLD linker support#6946
Conversation
Summary of ChangesHello @star-hengxing, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Clang toolchain configuration to properly support the LLD linker when Link-Time Optimization (LTO) is active. This change is crucial for resolving build issues, particularly for Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request enhances the Clang toolchain to use the LLD linker when Link-Time Optimization (LTO) is enabled on Windows. This is a good improvement. My review includes two points: one suggestion to improve code structure by moving an import statement, and a more critical fix for a logic issue that could cause conflicting linker flags to be applied when cross-compiling.
xmake/toolchains/clang/load.lua
Outdated
| toolchain:add("shflags", "-fuse-ld=lld-link") | ||
| end | ||
|
|
||
| if is_host("linux") then |
There was a problem hiding this comment.
if is_host("linux") or project.policy("build.optimization.lto") then
Fix package:on_test when enable lto