Conversation
waruqi
commented
Oct 17, 2025
- Before adding new features and new modules, please go to issues to submit the relevant feature description first.
- Write good commit messages and use the same coding conventions as the rest of the project.
- Please commit code to dev branch and we will merge into master branch in feature
- Ensure your edited codes with four spaces instead of TAB.
- 增加新特性和新模块之前，请先到issues提交相关特性说明，经过讨论评估确认后，再进行相应的代码提交，避免做无用工作。
- 编写友好可读的提交信息，并使用与工程代码相同的代码规范，代码请用4个空格字符代替tab缩进。
- 请提交代码到dev分支，如果通过，我们会在特定时间合并到master分支上。
- 为了规范化提交日志的格式，commit消息，不要用中文，请用英文描述。
Summary of ChangesHello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces significant improvements to Xmake's build job scheduling, particularly for custom build scripts. By transitioning from batch-based job processing to individual job creation for each source file, the changes aim to unlock greater parallelism and optimize build times for projects utilizing Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the build process to enable parallel execution of file-based jobs. By creating individual jobs for each source file instead of a single job for a batch, it allows the build system to leverage more parallelism, which should improve build times. The changes in both on_build_file and on_buildcmd_file handlers are consistent and correct. I have one minor suggestion to improve code maintainability by reducing some code duplication.
| if buildcmds then | ||
| -- only generate cmds and do not run them, use cases: e.g. project generator | ||
| if buildcmds then | ||
| local jobname = string.format("%s/%s", job_prefix, scriptcmd_file_name) | ||
| jobgraph:add(jobname, function (index, total, opt) | ||
| local sourcekind = sourcebatch.sourcekind | ||
| for _, sourcefile in ipairs(sourcebatch.sourcefiles) do | ||
| scriptcmd_file(target, buildcmds, sourcefile, {progress = opt.progress, sourcekind = sourcekind}) | ||
| end | ||
| else | ||
| local sourcekind = sourcebatch.sourcekind | ||
| for _, sourcefile in ipairs(sourcebatch.sourcefiles) do | ||
| end) | ||
| else | ||
| -- fall back to using batchcmd to process sourcefiles in parallel | ||
| local sourcekind = sourcebatch.sourcekind | ||
| for _, sourcefile in ipairs(sourcebatch.sourcefiles) do | ||
| local jobname = string.format("%s/%s/%s", job_prefix, scriptcmd_file_name, sourcefile) | ||
| jobgraph:add(jobname, function (index, total, opt) | ||
| local batchcmds_ = batchcmds.new({target = target}) | ||
| scriptcmd_file(target, batchcmds_, sourcefile, {progress = opt.progress, sourcekind = sourcekind, distcc = distcc}) | ||
| batchcmds_:runcmds({changed = target:is_rebuilt(), dryrun = option.get("dry-run")}) | ||
| end | ||
| end) | ||
| end | ||
| end) | ||
| end |
There was a problem hiding this comment.
The sourcekind variable is initialized in both branches of the if buildcmds statement (on lines 523 and 530). To avoid this duplication, you can define sourcekind once before this if block.
local sourcekind = sourcebatch.sourcekind
if buildcmds then
-- only generate cmds and do not run them, use cases: e.g. project generator
local jobname = string.format("%s/%s", job_prefix, scriptcmd_file_name)
jobgraph:add(jobname, function (index, total, opt)
for _, sourcefile in ipairs(sourcebatch.sourcefiles) do
scriptcmd_file(target, buildcmds, sourcefile, {progress = opt.progress, sourcekind = sourcekind})
end
end)
else
-- fall back to using batchcmd to process sourcefiles in parallel
for _, sourcefile in ipairs(sourcebatch.sourcefiles) do
local jobname = string.format("%s/%s/%s", job_prefix, scriptcmd_file_name, sourcefile)
jobgraph:add(jobname, function (index, total, opt)
local batchcmds_ = batchcmds.new({target = target})
scriptcmd_file(target, batchcmds_, sourcefile, {progress = opt.progress, sourcekind = sourcekind, distcc = distcc})
batchcmds_:runcmds({changed = target:is_rebuilt(), dryrun = option.get("dry-run")})
end)
end
end