refactor(toolchain): Separate gcc/clang registration from definition#6935
Conversation
…to prevent redundant loading
Summary of ChangesHello @romeoxbm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the internal structure of how GCC and Clang toolchains are defined and registered within the system. By decoupling the toolchain definition logic from its registration, the change aims to streamline the management of different compiler versions, reduce potential redundancies, and ultimately improve the overall maintainability and efficiency of the toolchain system. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request effectively refactors the GCC and Clang toolchain definitions by separating the definition logic from the registration calls. This is a great improvement that resolves redundant toolchain registration issues and enhances the clarity and maintainability of the codebase. The changes are well-structured and correctly implemented across all versioned toolchain files. I have a couple of minor suggestions to simplify path handling in toolchain_clang.lua.
|
|
||
| on_check(function (toolchain) | ||
| if toolchain:is_plat("windows") then | ||
| local rootdir = path.join(path.directory(os.scriptdir()), "clang") |
There was a problem hiding this comment.
The calculation of rootdir can be simplified. Since os.scriptdir() already points to the xmake/toolchains/clang/ directory where check.lua is located, you can directly assign it to rootdir.
local rootdir = os.scriptdir()
| toolchain:add("runtimes", "MT", "MTd", "MD", "MDd") | ||
| end | ||
| if toolchain:is_plat("windows", "mingw") then | ||
| local rootdir = path.join(path.directory(os.scriptdir()), "clang") |
There was a problem hiding this comment.
The calculation of rootdir can be simplified. Since os.scriptdir() already points to the xmake/toolchains/clang/ directory where load.lua is located, you can directly assign it to rootdir.
local rootdir = os.scriptdir()
This PR refactors the internal structure of the GCC and Clang toolchain definitions to separate their registration logic from their definition logic.
The change resolves redundant registration issues and improves both clarity and performance in versioned toolchains.