Skip to content

fix(C++ modules) if toolchain clang-scan-deps is not installed, fallback to system wide clang-scan-deps if available#6931

Merged
waruqi merged 1 commit intoxmake-io:devfrom
Arthapz:add-fallback-clang-scan-deps
Oct 16, 2025
Merged

fix(C++ modules) if toolchain clang-scan-deps is not installed, fallback to system wide clang-scan-deps if available#6931
waruqi merged 1 commit intoxmake-io:devfrom
Arthapz:add-fallback-clang-scan-deps

Conversation

@Arthapz
Copy link
Member

@Arthapz Arthapz commented Oct 15, 2025

No description provided.

@Arthapz
fix(C++ modules) if toolchain clang-scan-deps is not installed, fallb…
69db646 
…ack to system wide clang-scan-deps if available
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Oct 15, 2025

Summary of Changes

Hello @Arthapz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness of C++ module dependency scanning by introducing a fallback search for clang-scan-deps. This ensures that builds can proceed even if the tool is not present in the expected toolchain-specific location, by checking for a system-wide alternative. This change aims to improve build reliability and user experience when working with C++ modules.

Highlights

  • Toolchain Fallback: Implemented a fallback mechanism for clang-scan-deps. If the tool is not found within the specified toolchain's directory, the system will now attempt to locate a system-wide installation of clang-scan-deps.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 15, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds a fallback to search for a system-wide clang-scan-deps if one is not found alongside the clang toolchain. The implementation is clear and correct. I have one minor suggestion to improve conciseness.

@waruqi waruqi merged commit ac6062d into xmake-io:dev Oct 16, 2025
22 checks passed
@waruqi waruqi added this to the v3.0.5 milestone Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.0.5

Development

Successfully merging this pull request may close these issues.

2 participants

@Arthapz @waruqi