Skip to content

Add copy_if_different in os.cp#6918

Merged
waruqi merged 4 commits intodevfrom
cp
Oct 11, 2025
Merged

Add copy_if_different in os.cp#6918
waruqi merged 4 commits intodevfrom
cp

Conversation

@waruqi
Copy link
Member

@waruqi waruqi commented Oct 11, 2025

  • Before adding new features and new modules, please go to issues to submit the relevant feature description first.
  • Write good commit messages and use the same coding conventions as the rest of the project.
  • Please commit code to dev branch and we will merge into master branch in feature
  • Ensure your edited codes with four spaces instead of TAB.
  • 增加新特性和新模块之前，请先到issues提交相关特性说明，经过讨论评估确认后，再进行相应的代码提交，避免做无用工作。
  • 编写友好可读的提交信息，并使用与工程代码相同的代码规范，代码请用4个空格字符代替tab缩进。
  • 请提交代码到dev分支，如果通过，我们会在特定时间合并到master分支上。
  • 为了规范化提交日志的格式，commit消息，不要用中文，请用英文描述。

@waruqi waruqi added this to the v3.0.4 milestone Oct 11, 2025
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Oct 11, 2025

Summary of Changes

Hello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the os.cp utility by introducing a copy_if_different option, which optimizes file copy operations by ensuring files are only written if their content has actually changed. This improvement streamlines file management processes, reduces redundant disk I/O, and simplifies existing code that previously performed manual content comparisons before copying.

Highlights

  • New copy_if_different option: Introduced a new option for os.cp functions to only copy files if their content differs from the destination, preventing unnecessary writes.
  • Core C-level implementation: The xm_os_cpdir and xm_os_cpfile C functions were updated to accept and process the new TB_FILE_COPY_IF_DIFFERENT flag.
  • Lua API integration: The os._cp Lua function was modified to accept the copy_if_different option and pass it down to the underlying C functions.
  • Code simplification: Existing manual content comparison logic in _generate_configfile and rule("utils.symbols.export_list") was replaced with the new copy_if_different option, making the code cleaner and more efficient.
  • Subproject update: The tbox subproject was updated, likely containing the necessary C-level changes for the TB_FILE_COPY_IF_DIFFERENT flag.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 11, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a copy_if_different option to os.cp, which optimizes file copying by performing a content check and avoiding the copy if files are identical. This new feature is implemented in the tbox C library and exposed through to the Lua API. The PR then leverages this new option to simplify the logic in xmake/actions/config/configfiles.lua and xmake/rules/utils/symbols/export_list/xmake.lua, making the code cleaner and more efficient. The changes are well-implemented and a good improvement to the codebase.

@waruqi waruqi merged commit bd98673 into dev Oct 11, 2025
44 of 45 checks passed
@waruqi waruqi deleted the cp branch October 11, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.0.4

Development

Successfully merging this pull request may close these issues.

1 participant

@waruqi