package download: don't get submodules if disabled#6901
Conversation
Summary of ChangesHello @SirLynix, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a bug in the package download process where Git submodules were being cloned despite being explicitly disabled by the user. The change introduces conditional logic to the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly implements the logic to avoid cloning submodules when submodules = false is specified for a package dependency defined by a git tag. However, this fix appears to be incomplete as it doesn't cover the case where a package dependency is defined by a branch. The same logic should be applied to the git.clone call for branches on line 112 to fully resolve the issue.
| local clone_submodules = opt.url_submodules ~= false | ||
| git.clone(url, {depth = 1, recursive = clone_submodules, shallow_submodules = clone_submodules, longpaths = longpaths, branch = tag, outputdir = packagedir}) |
There was a problem hiding this comment.
This change correctly handles the submodules = false option for git tags. However, the same logic is missing for git branches. To fully fix the issue, a similar change should be applied to the git.clone call on line 112 for cloning branches.
should fix https://github.com/xmake-io/xmake-repo/actions/runs/18327237141/job/52194556351?pr=8344 where submodules were disabled
but were still cloned