Conversation
waruqi
commented
Oct 6, 2025
- Before adding new features and new modules, please go to issues to submit the relevant feature description first.
- Write good commit messages and use the same coding conventions as the rest of the project.
- Please commit code to dev branch and we will merge into master branch in feature
- Ensure your edited codes with four spaces instead of TAB.
- 增加新特性和新模块之前，请先到issues提交相关特性说明，经过讨论评估确认后，再进行相应的代码提交，避免做无用工作。
- 编写友好可读的提交信息，并使用与工程代码相同的代码规范，代码请用4个空格字符代替tab缩进。
- 请提交代码到dev分支，如果通过，我们会在特定时间合并到master分支上。
- 为了规范化提交日志的格式，commit消息，不要用中文，请用英文描述。
Summary of ChangesHello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces comprehensive unit tests for the random number generation functions within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds tests for the hash.rand* functions. The tests aim to check for collisions by generating 100,000 hashes and ensuring they are all unique. However, all three tests contain a critical logical bug where they store the loop index instead of the generated hash, making the collision check ineffective. I've provided suggestions to fix this. Additionally, the test for rand32 is likely to be flaky due to the high probability of collisions for a 32-bit hash space over 100,000 iterations, and I've included a note about this in the relevant comment.
tests/modules/hash/test.lua
Outdated
| for i = 1, 100000 do | ||
| local r = hash.rand32() | ||
| t:require(set[r] == nil) | ||
| set[i] = true |
There was a problem hiding this comment.
There's a logical error here. You're storing the loop index i in the set, not the generated random hash r. This makes the collision check on the previous line (t:require(set[r] == nil)) ineffective.
Additionally, for a 32-bit hash, checking for zero collisions in 100,000 iterations is likely to create a flaky test. The birthday problem predicts a high probability of at least one collision, which would cause this test to fail. You might want to reconsider the test's assertion.
set[r] = true
tests/modules/hash/test.lua
Outdated
| for i = 1, 100000 do | ||
| local r = hash.rand64() | ||
| t:require(set[r] == nil) | ||
| set[i] = true |
There was a problem hiding this comment.
There is a logical error in this test. You are storing the loop index i in the set, but you should be storing the generated random hash r. Because of this, the test doesn't check for hash collisions as intended. The check on the previous line t:require(set[r] == nil) will not work correctly.
set[r] = true
tests/modules/hash/test.lua
Outdated
| for i = 1, 100000 do | ||
| local r = hash.rand128() | ||
| t:require(set[r] == nil) | ||
| set[i] = true |
There was a problem hiding this comment.
This test has the same logical error as the others. The generated hash r is not being stored in the set. Instead, the loop index i is stored. This makes the collision check on the previous line (t:require(set[r] == nil)) ineffective. You should store r in the set to correctly test for collisions.
set[r] = true
8354364 to
f7c5709
Compare
696d73f to
69caeb3
Compare