Skip to content

add versionfiles checker#6876

Merged
waruqi merged 3 commits intoxmake-io:devfrom
Shiffted:fix-package-version-list
Oct 1, 2025
Merged

add versionfiles checker#6876
waruqi merged 3 commits intoxmake-io:devfrom
Shiffted:fix-package-version-list

Conversation

@Shiffted
Copy link
Contributor

@Shiffted Shiffted commented Sep 30, 2025

and fixes a crash when a versionfile can't be found.

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Sep 30, 2025

Summary of Changes

Hello @Shiffted, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the robustness and validation capabilities of the package management system. It introduces a dedicated checker for versionfiles to ensure that package configurations correctly reference existing files. Furthermore, the underlying API checking mechanism has been made more flexible, allowing for context-specific validations to be triggered. A critical fix is also included to prevent crashes during versionfile lookup, enhancing overall stability.

Highlights

  • New Versionfiles Checker: A new checker has been introduced to validate the existence and content of versionfiles specified within package configurations, ensuring their integrity.
  • Flexible API Checking: The check_api function has been enhanced to allow for conditional execution of checkers, enabling specific validations to run based on context, such as during package loading or after a download failure.
  • Crash Fix for Versionfile Resolution: A potential crash related to versionfile path resolution has been addressed, specifically when the self:base() object might be nil, making the system more robust.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Sep 30, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new checker for versionfiles in packages, which is triggered on download failure. It also includes a fix for a potential crash in package.lua when a versionfile cannot be found because its base package doesn't exist. The changes are well-structured, but I've found an issue in the implementation of the new versionfiles checker where it doesn't correctly resolve file paths, which could lead to incorrect validation results. My review includes a suggestion to fix this.

@Shiffted Shiffted force-pushed the fix-package-version-list branch from 8bc3c31 to c0f62e7 Compare September 30, 2025 13:55
@Shiffted Shiffted force-pushed the fix-package-version-list branch from c0f62e7 to 8b2d1c2 Compare September 30, 2025 14:06
@waruqi waruqi merged commit 291bfbe into xmake-io:dev Oct 1, 2025
22 checks passed
@waruqi waruqi added this to the v3.0.4 milestone Oct 1, 2025
@Shiffted Shiffted deleted the fix-package-version-list branch November 2, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.0.4

Development

Successfully merging this pull request may close these issues.

2 participants

@Shiffted @waruqi