chore(vcpkg): bump default baseline hash of vcpkg#6870
Conversation
Update the default vcpkg baseline to a more recent commit (2025.09.27) to ensure xmake uses up-to-date vcpkg ports.
Summary of ChangesHello @yingmanwumen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the internal reference for the vcpkg package manager within xmake. By bumping the default baseline hash to a more recent commit, xmake will now leverage a newer set of vcpkg ports, ensuring access to updated dependencies and potentially improved compatibility or features for projects using vcpkg through xmake. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the default vcpkg baseline hash, which is a good maintenance task. My review includes one suggestion to correct a likely typo in the date associated with the new commit hash in the code comment. This will help maintain the accuracy of the code's documentation and prevent confusion. Please note that the same typo appears in the pull request description.
|
|
||
| -- generate manifest, vcpkg.json | ||
| local baseline = configs.baseline or "44d94c2edbd44f0c01d66c2ad95eb6982a9a61bc" -- 2021.04.30 | ||
| local baseline = configs.baseline or "2e6fcc44573d091af0321f99c89b212997a76f1f" -- 2025.09.27 |
There was a problem hiding this comment.
The date in the comment, 2025.09.27, appears to have a typo in the year. A git commit is a historical record and cannot have a date from the future. The correct year for this commit hash is likely 2023. Updating the comment to be accurate will improve clarity and prevent confusion for other developers.
local baseline = configs.baseline or "2e6fcc44573d091af0321f99c89b212997a76f1f" -- 2023.09.27
Update the default vcpkg baseline to a more recent commit (2025.09.27) to ensure xmake uses up-to-date vcpkg ports.