fix(C++ modules) fix stdmodule priority#6809
Conversation
f8b7cd0 to
c403203
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request addresses an issue with C++ standard module priority by correctly caching stdmodules based on the C++ standard library in use. This is a significant improvement for projects that utilize multiple toolchains. The changes also introduce new tests to validate this behavior and refactor some existing module support code for better organization. My review focuses on enhancing the new test scripts for clarity and robustness, and simplifying some of the newly introduced logic for better maintainability.
b6579d4 to
98f86e3
Compare
There was a problem hiding this comment.
Code Review
This pull request fixes an issue with stdmodule priority when using multiple runtimes by caching stdmodule information per C++ library. The core logic change in xmake/rules/c++/modules/support.lua correctly isolates the caches. The pull request also includes a new test case to verify this fix, along with some refactoring and bug fixes in existing test files. The changes look solid and effectively address the problem. I have one suggestion to improve the readability and maintainability of the new test file by reducing code duplication.
There was a problem hiding this comment.
Code Review
This pull request correctly fixes an issue with C++ standard module caching when multiple runtimes are used by scoping the cache to the specific C++ library implementation. The change is supported by refactoring a helper function to a shared location and adding a new test case to verify the fix. The overall changes are well-structured and improve the robustness of C++ module support. I have one suggestion to improve a new test file by reducing code duplication and improving consistency.
39ce9c2 to
4f44e3c
Compare
35a1e91 to
a3b5597
Compare
2559764 to
c83393a
Compare
c83393a to
bcc3c56
Compare
|
Does it ready now? |
Yes |
1 similar comment
Yes |
fixes #6794