feat(wdk rules) enable support of incomplete wdk#6796
Merged
waruqi merged 2 commits intoxmake-io:devfrom Sep 14, 2025
Merged
Conversation
Member
why do not use xmake/xmake/modules/detect/sdks/find_wdk.lua Line 162 in e641d13 Using set_values to set hard-coded paths is not recommended. and we can also use |
…ting wdk.sdkdir target value)
5e2a050 to
e031b87
Compare
Member
Author
my bad didn't saw it :D, i removed bits about wdk directory |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR allow the user setting the path of WDK directory and only assert for the missing binaries when they are needed (for exemple nuget WDK doesn't ship all of these binary)