feat(C++ modules support) use a file for requires flags when --verbose or --diagnosis is supplied#6744
Merged
waruqi merged 3 commits intoxmake-io:devfrom Sep 9, 2025
Merged
Conversation
…e or --diagnosis is supplied
Closed
Member
|
Does it ready now? |
Member
Author
|
it is, i was justs waiting for @MacroModel to know if it's what he want |
waruqi
reviewed
Sep 9, 2025
| for _, flag in ipairs(requiresflags) do | ||
| -- we need to wrap flag to support flag with space | ||
| if type(flag) == "string" and flag:find(" ", 1, true) and not hide_dependencies then | ||
| table.insert(cxxflags, {flag}) |
waruqi
reviewed
Sep 9, 2025
|
|
||
| import foo; | ||
|
|
||
| int main() { |
Member
There was a problem hiding this comment.
int main(int argc, char** argv) {
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR add a new policy
build.c++.modules.hide_dependency(default to false) that enable passing requires flags as a file to reduce build log noise when compiling with -v (only impact msvc and clang as gcc already use a mapper file that do the same thing)and make -D print the mapping like for gcc
before ---------
-v:
-D
-vD:
after ---------
-v:
-D
-vD:
