fix(qt.qmltyperegistrar): Extend dependencies for rebuild#6735
Merged
waruqi merged 2 commits intoxmake-io:devfrom Aug 21, 2025
Merged
fix(qt.qmltyperegistrar): Extend dependencies for rebuild#6735waruqi merged 2 commits intoxmake-io:devfrom
waruqi merged 2 commits intoxmake-io:devfrom
Conversation
- Add values (import name, import version) to dependencies. - Add corresponding headers to dependencies as we need to re-generate `plugin.qmltypes`.
waruqi
reviewed
Aug 21, 2025
waruqi
reviewed
Aug 21, 2025
GooRoo
commented
Aug 21, 2025
Comment on lines
+129
to
+130
| batchcmds:add_depvalues({importname, majorversion, minorversion}) | ||
| batchcmds:add_depfiles(table.join(sourcebatch.sourcefiles, sourcefile)) |
Contributor
Author
There was a problem hiding this comment.
@waruqi Not sure if you're aware, but GitHub has this quite handy feature called suggestions (there is a button on the toolbar). JFYI.
Suggested change
| batchcmds:add_depvalues({importname, majorversion, minorversion}) | |
| batchcmds:add_depfiles(table.join(sourcebatch.sourcefiles, sourcefile)) | |
| batchcmds:add_depvalues(importname, majorversion, minorversion) | |
| batchcmds:add_depfiles(sourcefile, sourcebatch.sourcefiles) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
plugin.qmltypes.Fixes #6734.