Merged
Conversation
修复了这样的问题:使用android ndk构建rust源码时,rustc不会将link-args="..."的等号之后的引号特殊处理,导致传递给clang++类似'"-llog'的错误的参数。
waruqi
reviewed
Aug 20, 2025
xmake/toolchains/ndk/load.lua
Outdated
| toolchain:add("rcldflags", "-C link-args=\"" .. (table.concat(rcldflags, " "):gsub("%-march=.-%s", "") .. "\"")) | ||
| -- fix [[note: clang++: error: no such file or directory: '"-llog']] on windows | ||
| -- @note 'link-args=...' should not be 'link-args="..."' | ||
| toolchain:set("rcshflags", {"-C", "link-args=" .. (table.concat(rcshflags, " "):gsub("%-march=.-%s", ""))}, {expand=false}) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复了这样的问题:使用android ndk构建rust源码时,rustc不会将link-args="..."的等号之后的引号特殊处理,导致传递给clang++类似'"-llog'的错误的参数。