fix(qt.qmltyperegistrar): Collect metatypes info#6648
Merged
waruqi merged 2 commits intoxmake-io:devfrom Jul 24, 2025
Merged
Conversation
Instead of passing all JSON-files generated by MOC directly into `qmltyperegistrar`, combine them into a single JSON-file first using MOC. Resolves xmake-io#6647.
waruqi
reviewed
Jul 23, 2025
| "--major-version=" .. majorversion, | ||
| "--minor-version=" .. minorversion, | ||
| "-o", sourcefile | ||
| "-o", sourcefile, |
Member
There was a problem hiding this comment.
please use path(sourcefile) to wrap all file path, project generator will handle path better.
Contributor
Author
There was a problem hiding this comment.
Wrapped in path() at the initialization.
waruqi
reviewed
Jul 23, 2025
waruqi
reviewed
Jul 23, 2025
waruqi
reviewed
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of passing all JSON-files generated by MOC directly into
qmltyperegistrar, combine them into a single JSON-file first using MOC.Resolves #6647.