Use unique source-batch for unity build#6440
Closed
MaxwellGengYF wants to merge 1 commit intoxmake-io:devfrom
MaxwellGengYF:dev
Closed
Use unique source-batch for unity build#6440MaxwellGengYF wants to merge 1 commit intoxmake-io:devfrom MaxwellGengYF:dev
MaxwellGengYF wants to merge 1 commit intoxmake-io:devfrom
MaxwellGengYF:dev
Conversation
Member
|
基于你这个 patch 改了下,唯一性应该在 rule 定义的时候被标记,而不是在某个特定的 unitybuild rule 里面。 否则如果有其他 rule 也会去改 sourcebatches ,同样会有类似问题,应该从源头去配置定义。后面也方便其他地方使用这个状态。 你可以试试 #6446 |
Based on your patch, uniqueness should be marked when the rule is defined, rather than in a specific unitybuild rule. Otherwise, if there are other rules, the sourcebatches will also be modified, and there will be similar problems. The definition should be configured from the source. This state is also convenient for other places to use later. You can try #6446 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6420