Skip to content

Use unique source-batch for unity build#6440

Closed
MaxwellGengYF wants to merge 1 commit intoxmake-io:devfrom
MaxwellGengYF:dev
Closed

Use unique source-batch for unity build#6440
MaxwellGengYF wants to merge 1 commit intoxmake-io:devfrom
MaxwellGengYF:dev

Conversation

@MaxwellGengYF
Copy link
Contributor

@waruqi
Copy link
Member

waruqi commented May 15, 2025

基于你这个 patch 改了下,唯一性应该在 rule 定义的时候被标记,而不是在某个特定的 unitybuild rule 里面。

否则如果有其他 rule 也会去改 sourcebatches ,同样会有类似问题,应该从源头去配置定义。后面也方便其他地方使用这个状态。

你可以试试 #6446

@waruqi waruqi closed this May 15, 2025
@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


Based on your patch, uniqueness should be marked when the rule is defined, rather than in a specific unitybuild rule.

Otherwise, if there are other rules, the sourcebatches will also be modified, and there will be similar problems. The definition should be configured from the source. This state is also convenient for other places to use later.

You can try #6446

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants