Fixed cmake generator that was using 'CMAKE_COMPILER_ID' #6439
Merged
waruqi merged 8 commits intoxmake-io:devfrom May 16, 2025
Merged
Fixed cmake generator that was using 'CMAKE_COMPILER_ID' #6439waruqi merged 8 commits intoxmake-io:devfrom
waruqi merged 8 commits intoxmake-io:devfrom
Conversation
…t exists, instead of CMAKE_CXX_COMPILER_ID
Member
|
Which one is more correct? #6438 |
PierreEVEN
commented
May 14, 2025
…D instead of real value
commit ab0a145 Author: PierreEVEN <spam@evenpierre.fr> Date: Wed May 14 11:16:49 2025 +0200 fixed CMAKE_COMPILER_ID value that was set to CMAKE_<LANG>_COMPILER_ID instead of real value commit edf7b7f Author: PierreEVEN <spam@evenpierre.fr> Date: Wed May 14 11:06:42 2025 +0200 Use project language to detect compiler ID
….com:PierreEVEN/xmake into fix-cmake_generator-wrong_cmake_var_compiler
Contributor
Author
I've just fixed this PR which now handles any language so it's better in theory. |
…id potential conflicts
waruqi
reviewed
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix previous merge that failed to fix issue with compiler detection (was not a regression, but neither a progress)
CMAKE_COMPILER_ID is not the right variable (but works in certain conditions)
The right one is CMAKE__CXX_COMPILER_ID
Now it should be the right one.